host_name or host is required not both #1045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes shopify_app #1542 reported issue where new installs were breaking due to still requiring
host_name
whenhost
was present.host
is the preferred and new default configuration option to makelocahost
the defaultAdds
pry-byebug
as dev dependency to make debugging easierHow has this been tested?
New app install with localhost
shopify_app
and ran the install generator.gem "shopify_api", path: "../shopify-api-ruby"
to my Gemfile and ranbundle install
HOST
and API keys as ENV variableshost_name
error being thrown as the reported in issueusing a tunnel and only
host_name
confighost_name
context setup attribute instead of ENV variable. This app also uses a tunnel to get TLS on local devgem "shopify_api", path: "../shopify-api-ruby"
to my Gemfile and ranbundle install
Checklist: