Add new method to construct host app URL #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
force-pushed
the
kos/add_auth_embedded_app_url
branch
from
8d49a90 to
310e24c
Compare
Use Base64.strict_encode64 (to avoid adding newlines), but Base64.decode64 (using strict_decode64 breaks with what's provided by Shopify)
mkevinosullivan
force-pushed
the
kos/add_auth_embedded_app_url
branch
from
310e24c to
6639607
Compare
mkevinosullivan
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For performance soon we will be recommending that apps favour server redirects within the OAuth process. This will replace client side redirects using AppBridge. We want to control that code that constructs the URL for the app. That way it's easier for developers, and if that URL changes we can update the logic with a version bump.
This utility will be used to get the URL to redirect to when the store does not have a token for the app.
Ruby API equivalent of Shopify/shopify-api-js#419
Closes https://github.com/Shopify/first-party-library-planning/issues/392
What is this pull request doing?
Add a new utility called
ShopifyAPI::Auth.embedded_app_url. This utility constructs the host URL for an embedded app.How has this been tested?
Unit tests added to test green path as well as error paths.
Checklist: