Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add new method to construct host app URL #1001

Closed
wants to merge 2 commits into from

Conversation

mkevinosullivan
Copy link
Contributor

Description

For performance soon we will be recommending that apps favour server redirects within the OAuth process. This will replace client side redirects using AppBridge. We want to control that code that constructs the URL for the app. That way it's easier for developers, and if that URL changes we can update the logic with a version bump.

This utility will be used to get the URL to redirect to when the store does not have a token for the app.

Ruby API equivalent of Shopify/shopify-api-js#419

What is this pull request doing?

Add a new utility called ShopifyAPI::Utils::AppUrl.getEmbedded. This utility constructs the host URL for an embedded app.

How has this been tested?

Unit tests added to test green path as well as error paths.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@mkevinosullivan mkevinosullivan deleted the kos/add_AppUrl-getEmbedded branch August 5, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant