Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webrick as a gem dependency #884

Closed
toncid opened this issue Oct 27, 2021 · 1 comment
Closed

Webrick as a gem dependency #884

toncid opened this issue Oct 27, 2021 · 1 comment

Comments

@toncid
Copy link

toncid commented Oct 27, 2021

Issue summary

As of v9.5 Webrick is a shopify_api gem dependency, which is very strange to see.

Expected behavior

It is strange to see it as a dependency, Webrick should be optional.

Actual behavior

The v9.5 of the gem now lists webrick as a dependency:

    shopify_api (9.5)
      activeresource (>= 4.1.0, < 6.0.0)
      graphql-client
      rack
      webrick  <<<<<<<<<<<<<<<<

Steps to reproduce the problem

  1. Upgrade the shopify_api gem to v9.5.

Logs

N/A

Specifications

  • shopify_api version: v9.5
  • activeresource version: v5.1.1
  • Shopify API version used (example: 2020-07): N/A
@andyw8
Copy link
Contributor

andyw8 commented Oct 27, 2021

Webrick was added for compatibility with Ruby 3:

#883

@andyw8 andyw8 closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants