Support for ruby 3.0 #883
Merged
Support for ruby 3.0 #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-ruby-3-0-support
branch
from
06d853a to
a3199c2
Compare
|
Perhaps we can test core against this branch to verify? |
|
Let's also update |
Will do.
WIll do. |
flavorjones
force-pushed
the
flavorjones-ruby-3-0-support
branch
from
185e5d5 to
5b6ed0f
Compare
paulomarg
approved these changes
Oct 6, 2021
|
Please note at https://github.com/Shopify/shopify/pull/316649 represents a green test suite against this branch (modulo some attribute changes related to upgrading I think this is ready for review. |
flavorjones
force-pushed
the
flavorjones-ruby-3-0-support
branch
from
5b6ed0f to
7e9a8bd
Compare
Add tests describing the encoding behaviors for keys and values during signature validation. These tests are _descriptive_ of the current behavior, and not _prescriptive_.
Replace it with similar methods from WEBrick::HTTPUtils. Note that this introduces webrick as an explicit dependency because webrick is available as a separate gem, and because Ruby 3.0 ships without it in the standard library.
instead of string equivalence.
instead of URI.escape which is deprecated.
flavorjones
force-pushed
the
flavorjones-ruby-3-0-support
branch
from
7e9a8bd to
714c86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset allows
shopify_apito run with Ruby 3.0. The notable changes introduced are:URI.escapeusage in HMAC-signature parameter handling withWEBrick::HTTPUtilsmethod callsURI.escapeusage in OAuth URL construction withURI.encode_www_formNote that tests have been added around the parameter-handling as it relates to HMAC signature validation, because the keys and values are encoded differently and in very specific ways. I've tried to reproduce the existing behavior insofar as I understand it.
Note that URI equivalence in the tests is now asserted by using
Addressable::URI#equalsinstead of directly comparing strings. There are small differences in howURI.encode_www_formencodes CGI parameters (compared toURI.escape), but they're not semantic differences.