Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(📹): Video support on Web #2477

Merged
merged 13 commits into from
Jun 13, 2024
Prev Previous commit
Next Next commit
remove bogus comment
  • Loading branch information
wcandillon committed Jun 12, 2024
commit 486d0bb0284b3e3c30d0a17cc3d6bcb0bb676a49
3 changes: 0 additions & 3 deletions package/android/cpp/jni/JniPlatformContext.cpp
Original file line number Diff line number Diff line change
@@ -87,9 +87,6 @@ JniPlatformContext::createVideo(const std::string &url) {
// Convert std::string to jstring
jstring jUrl = env->NewStringUTF(url.c_str());

// Get the method ID for the createVideo method
// Replace "Lcom/yourpackage/RNSkVideo;" with the actual return type
// descriptor
static auto method =
javaPart_->getClass()->getMethod<jobject(jstring)>("createVideo");