Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize variable names in tests #346

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Uniformize variable names in tests #346

merged 1 commit into from
Aug 6, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Aug 6, 2024

Always use the same variable names when it make sense.

tree = parse_rbi("RBI input")
assert_equal("expected RBI output", tree.string)

when we need the original RBI input around:

rbi = "RBI input"
tree = parse_rbi(rbi)
assert_equal(rbi, tree.string)

@Morriar
Uniformize variable names in tests
9dae5b5 
Signed-off-by: Alexandre Terrasa <[email protected]>
@Morriar Morriar added the chore Chore task label Aug 6, 2024
@Morriar Morriar self-assigned this Aug 6, 2024
@Morriar Morriar requested a review from a team as a code owner August 6, 2024 14:36
@Morriar Morriar requested review from amomchilov and egiurleo August 6, 2024 14:36
@Morriar Morriar merged commit 34c5f7f into main Aug 6, 2024
8 checks passed
@Morriar Morriar deleted the at-test-renaming branch August 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

@amomchilov amomchilov Awaiting requested review from amomchilov amomchilov is a code owner automatically assigned from Shopify/sorbet

Assignees

@Morriar Morriar

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @egiurleo