Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of dangling things #344

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Fix parsing of dangling things #344

merged 2 commits into from
Aug 5, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Aug 5, 2024

Comments dangling from a scope where returned reversed:

module M
  # comment 1
  # comment 2
end

was returning:

module M
  # comment 2
  # comment 1
end

Signatures left dangling at the end of a scope where ignored:

module M
  sig { void }
end

so the RBI built looked like:

module M
end

Morriar added 2 commits August 5, 2024 16:39
Signed-off-by: Alexandre Terrasa <[email protected]>
@Morriar Morriar added the bugfix Fix a bug label Aug 5, 2024
@Morriar Morriar self-assigned this Aug 5, 2024
@Morriar Morriar requested a review from a team as a code owner August 5, 2024 20:44
@Morriar Morriar requested review from amomchilov and egiurleo August 5, 2024 20:44
@Morriar Morriar merged commit c8dc0c1 into main Aug 5, 2024
8 checks passed
@Morriar Morriar deleted the at-fix-parse-dangling branch August 5, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants