Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of visibility send #341

Merged
merged 1 commit into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/rbi/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,13 @@ def visit_call_node(node)
case last_node
when Method, Attr
last_node.visibility = parse_visibility(node.name.to_s, node)
when Send
current_scope << Send.new(
message,
parse_send_args(node.arguments),
loc: node_loc(node),
comments: node_comments(node),
)
else
raise ParseError.new(
"Unexpected token `#{node.message}` before `#{last_node&.string&.strip}`",
Expand Down
1 change: 1 addition & 0 deletions test/rbi/parser_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ def test_parse_arbitrary_sends
class ActiveRecord::Base
class_attribute :typed_stores, :store_accessors, instance_accessor: false, default: "Foo"
foo bar, "bar", :bar
private :foo
end
RBI

Expand Down
Loading