Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing of signatures with final modifier in block #318

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix printing of signatures with final modifier in block #318

merged 1 commit into from
Jul 8, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 2, 2024

Fixes #316.

@Morriar Morriar added the bugfix Fix a bug label Jul 2, 2024
@Morriar Morriar self-assigned this Jul 2, 2024
@Morriar Morriar requested a review from a team as a code owner July 2, 2024 14:33
@Morriar Morriar requested review from amomchilov and egiurleo July 2, 2024 14:33
@Morriar Morriar mentioned this pull request Jul 2, 2024
Closed
@Morriar Morriar merged commit 5ed2840 into main Jul 8, 2024
8 checks passed
@Morriar Morriar deleted the at-fix-final branch July 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

@amomchilov amomchilov Awaiting requested review from amomchilov amomchilov is a code owner automatically assigned from Shopify/sorbet

Assignees

@Morriar Morriar

Labels
bugfix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Final modifier is omitted when signature is rendered as block
2 participants
@Morriar @egiurleo