Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use Minitest::Reporter for RubyMine #314

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Don't use Minitest::Reporter for RubyMine #314

merged 1 commit into from
Jul 15, 2024

Conversation

amomchilov
Copy link
Contributor

@amomchilov amomchilov commented Jun 17, 2024 •
edited
Loading

Workaround for this issue.

@amomchilov amomchilov added the chore Chore task label Jun 17, 2024
@amomchilov amomchilov self-assigned this Jun 17, 2024
@amomchilov amomchilov force-pushed the Alex/RubyMine-support branch from 22a7681 to c9f9211 Compare June 18, 2024 14:54
@amomchilov amomchilov marked this pull request as ready for review June 18, 2024 14:54
@amomchilov amomchilov requested a review from a team as a code owner June 18, 2024 14:54
@amomchilov amomchilov requested review from egiurleo and KaanOzkan June 18, 2024 14:54
KaanOzkan
KaanOzkan approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, we'll remove when it's resolved.

@amomchilov amomchilov merged commit 8df5c93 into main Jul 15, 2024
8 checks passed
@amomchilov amomchilov deleted the Alex/RubyMine-support branch July 15, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo is a code owner automatically assigned from Shopify/sorbet

Assignees

@amomchilov amomchilov

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amomchilov @KaanOzkan