Merge pull request #341 from Shopify/at-fix-parser-vis-send

Fix parsing of visibility send
Shopify · Aug 6, 2024 · b5404f5 · b5404f5
2 parents 968c8f5 + 6efb358
commit b5404f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/rbi/parser.rb b/lib/rbi/parser.rb
@@ -434,6 +434,13 @@ def visit_call_node(node)
             case last_node
             when Method, Attr
               last_node.visibility = parse_visibility(node.name.to_s, node)
+            when Send
+              current_scope << Send.new(
+                message,
+                parse_send_args(node.arguments),
+                loc: node_loc(node),
+                comments: node_comments(node),
+              )
             else
               raise ParseError.new(
                 "Unexpected token `#{node.message}` before `#{last_node&.string&.strip}`",

diff --git a/test/rbi/parser_test.rb b/test/rbi/parser_test.rb
@@ -354,6 +354,7 @@ def test_parse_arbitrary_sends
         class ActiveRecord::Base
           class_attribute :typed_stores, :store_accessors, instance_accessor: false, default: "Foo"
           foo bar, "bar", :bar
+          private :foo
         end
       RBI