Merge pull request rails#42290 from brunvez/top_level_update_error_me…

…ssage

Fix error message on top level update when sending an array of records

activerecord/lib/active_record/persistence.rb

@@ -308,6 +308,11 @@ def instantiate(attributes, column_types = {}, &block)
       # for updating all records in a single query.
       def update(id = :all, attributes)
         if id.is_a?(Array)
+          if id.any?(ActiveRecord::Base)
+            raise ArgumentError,
+              "You are passing an array of ActiveRecord::Base instances to `update`. " \
+              "Please pass the ids of the objects by calling `pluck(:id)` or `map(&:id)`."
+          end
           id.map { |one_id| find(one_id) }.each_with_index { |object, idx|
             object.update(attributes[idx])
           }

activerecord/test/cases/persistence_test.rb

@@ -64,6 +64,18 @@ def test_update_many_with_active_record_base_object
     assert_not_equal "1 updated", Topic.first.content
   end
 
+  def test_update_many_with_array_of_active_record_base_objects
+    error = assert_raise(ArgumentError) do
+      Topic.update(Topic.first(2), content: "updated")
+    end
+
+    assert_equal "You are passing an array of ActiveRecord::Base instances to `update`. " \
+    "Please pass the ids of the objects by calling `pluck(:id)` or `map(&:id)`.", error.message
+
+    assert_not_equal "updated", Topic.first.content
+    assert_not_equal "updated", Topic.second
+  end
+
   def test_class_level_update_without_ids
     topics = Topic.all
     assert_equal 5, topics.length