Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SG] Add Archery Accessories and relocate categories #495

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ricardotejedorsanz
Copy link
Contributor

Pending cleaning up of the Archery area by relocating accessories categories within a single parent Archery Accessories:
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 12 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • data/integrations/google/2021-09-21/mappings/from_shopify.yml: Evaluated as low risk
  • data/localizations/categories/en.yml: Evaluated as low risk
Comments skipped due to low confidence (6)

data/categories/sg_sporting_goods.yml:11373

  • The new category ID 'sg-4-9-1-11' should be consistent with the existing format. Consider using 'sg-4-9-1-11' for consistency.
- id: sg-4-9-1-11

data/categories/sg_sporting_goods.yml:11386

  • The new category ID 'sg-4-9-1-11-1' should be consistent with the existing format. Consider using 'sg-4-9-1-11-1' for consistency.
- id: sg-4-9-1-11-1

data/categories/sg_sporting_goods.yml:11396

  • The new category ID 'sg-4-9-1-11-2' should be consistent with the existing format. Consider using 'sg-4-9-1-11-2' for consistency.
- id: sg-4-9-1-11-2

data/categories/sg_sporting_goods.yml:11408

  • The new category ID 'sg-4-9-1-11-3' should be consistent with the existing format. Consider using 'sg-4-9-1-11-3' for consistency.
- id: sg-4-9-1-11-3

data/categories/sg_sporting_goods.yml:11418

  • The new category ID 'sg-4-9-1-11-4' should be consistent with the existing format. Consider using 'sg-4-9-1-11-4' for consistency.
- id: sg-4-9-1-11-4

data/categories/sg_sporting_goods.yml:11426

  • The new category ID 'sg-4-9-1-11-5' should be consistent with the existing format. Consider using 'sg-4-9-1-11-5' for consistency.
- id: sg-4-9-1-11-5
@ricardotejedorsanz ricardotejedorsanz force-pushed the sg-add-archery-accessories branch from b419a99 to 4b061b2 Compare December 11, 2024 10:31
@ricardotejedorsanz ricardotejedorsanz merged commit dceb2b6 into main Dec 11, 2024
5 checks passed
@ricardotejedorsanz ricardotejedorsanz deleted the sg-add-archery-accessories branch December 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 shopify-mappings taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants