Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-shopify and stylelint-config-shopify versions #835

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Jan 8, 2019

WHY are these changes introduced?

VSCode's stylelint extension checks on typing. Sometimes when you're typing you write unparsable code - because you've wrote if { but not the } yet.

When this happens you get a bunch of problem notifications raised because prior to this change eslint and stylelint crashed when given unparsable code:

screen shot 2019-01-07 at 1 02 40 pm

WHAT is this pull request doing?

This bumps the versions of the eslint and stylelint prettier plugins to not crash when faced
with invalid code, so these errors-because-youve-not-finished-typing are denoted as temporary red squiggly lines instead of those problem popups.

How to 🎩

  • Have the stylelint VSCode plugin installed
  • yarn install
  • Restart VSCode
  • Write some unparsable code in a tsx file. I suggest changing an export to ex}port. See that no problem notification appears

This bumps the versions of the prettier plugins to not crash when faced
with invalid code
@BPScott BPScott merged commit 18a9ea9 into master Jan 8, 2019
@BPScott BPScott deleted the bump-prettier-plugins branch January 8, 2019 22:25
@BPScott BPScott temporarily deployed to beta January 10, 2019 20:44 Inactive
@kaelig kaelig deployed to test-yarn-npx January 11, 2019 00:53 Active
@danrosenthal danrosenthal temporarily deployed to production January 16, 2019 18:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants