Bump eslint-plugin-shopify and stylelint-config-shopify versions #835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
VSCode's stylelint extension checks on typing. Sometimes when you're typing you write unparsable code - because you've wrote
if {
but not the}
yet.When this happens you get a bunch of problem notifications raised because prior to this change eslint and stylelint crashed when given unparsable code:
WHAT is this pull request doing?
This bumps the versions of the eslint and stylelint prettier plugins to not crash when faced
with invalid code, so these errors-because-youve-not-finished-typing are denoted as temporary red squiggly lines instead of those problem popups.
How to 🎩
yarn install
export
toex}port
. See that no problem notification appears