[TextField] Replace autocomplete off with nope #4053
Conversation
|
Just wanted to surface this SO answer, it seems that Chromium "fixed" this and then broke it again. We'll need to update all |
| }) | ||
| .join('\n'); | ||
| }; | ||
| const {storybookA11yTest} = require('@shopify/storybook-a11y-test'); |
There was a problem hiding this comment.
Unblocked by Shopify/quilt#1764
alex-page
force-pushed
the
autocomplete-off-attribute
branch
from
4d0438f to
a21ad68
Compare
dfmcphee
force-pushed
the
autocomplete-off-attribute
branch
from
a21ad68 to
8092455
Compare
|
This change is breaking auto complete in the theme editor. Is there a recommended way to fix it? https://screenshot.click/21-04-yqnd4-01tux.mp4
|
We saw one other case of this recently. Chrome seems to handle these in very strange ways where sometimes it can depend on the form around it and names and ids on the inputs as well. A work around for now is to use |
|
based on https://github.com/Shopify/polaris-react/pull/4053/files#diff-0476232e85245a025ae1fd330da91aae821feefc18fdd5f95d6f0a1e935c5292L520 change it doesn't look like a consumer can do that. Is there another way? Can we update the code to allow the consumer to pick between |
|
If you use |
|
Yes please. it will be cumbersome to update all text fields in the theme editor (and other places where autocomplete may not have broken similar to how it did for the editor but we don't know yet) |
|
I don't have time right now but have documented the problem #4107 |
WHY are these changes introduced?
Currently we use the attribute
autocomplete="off"on the<TextField>component when passing inautoComplete={false}.This causes issues in Chrome because of this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=468153
WHAT is this pull request doing?
This changes the attribute to be
autocomplete="nope"which looks strange but does work across browsers.