-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3700 DropZone document #3701
Conversation
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @malanjp, one suggestion.
Co-authored-by: Alex Page <[email protected]>
4eab9e5
to
9e09ba7
Compare
array.includes is pretty ubiquitous these days. What do you think to using that instead? validImageTypes.includes(file.type) |
How to pass CI/Visual regression test?
|
🎉 Thanks for your contribution to Polaris React! |
Thankyou @malanjp ✨ |
WHY are these changes introduced?
Fixes #3700
WHAT is this pull request doing?
Change from validImageTypes.indexOf(file.type) > 0 to validImageTypes.indexOf(file.type) > -1.