Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3700 DropZone document #3701

Merged
merged 10 commits into from
Feb 11, 2021
Merged

Conversation

malanjp
Copy link
Contributor

@malanjp malanjp commented Dec 10, 2020

WHY are these changes introduced?

Fixes #3700

WHAT is this pull request doing?

Change from validImageTypes.indexOf(file.type) > 0 to validImageTypes.indexOf(file.type) > -1.

@ghost
Copy link

ghost commented Dec 10, 2020

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost ghost added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Dec 10, 2020
@ghost ghost removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Dec 10, 2020
UNRELEASED.md Outdated Show resolved Hide resolved
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @malanjp, one suggestion.

Co-authored-by: Alex Page <[email protected]>
@alex-page alex-page force-pushed the master branch 2 times, most recently from 4eab9e5 to 9e09ba7 Compare January 15, 2021 05:17
@BPScott
Copy link
Member

BPScott commented Jan 16, 2021

array.includes is pretty ubiquitous these days. What do you think to using that instead?

validImageTypes.includes(file.type)

Base automatically changed from master to main January 21, 2021 15:38
@malanjp
Copy link
Contributor Author

malanjp commented Jan 23, 2021

How to pass CI/Visual regression test?

Chromatic CLI v5.5.0
chromatic.com/docs/cli

✖ Missing project token

Sign in to chromatic.com/start and create a new project,
or find your project token on the Manage screen in an existing project.
Set your project token as the CHROMATIC_PROJECT_TOKEN environment variable
or pass the --project-token command line option.

ℹ Read more at chromatic.com/docs/setup
Error: non-zero exit code

@alex-page alex-page merged commit f77fd90 into Shopify:main Feb 11, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

🎉 Thanks for your contribution to Polaris React!

@alex-page
Copy link
Member

Thankyou @malanjp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a file type detection error bug in DropZone documents
3 participants