Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PageActions] Update delete button to destructive button #2471

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

mirualves
Copy link
Contributor

WHAT is this pull request doing?

Updating the example on the style guide to follow best practices.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@mirualves mirualves requested a review from dleroux November 26, 2019 14:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2019

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@mirualves mirualves merged commit 78adc3a into master Nov 27, 2019
@mirualves mirualves deleted the update-pageaction-example branch November 27, 2019 14:16
@dleroux dleroux temporarily deployed to production December 4, 2019 14:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants