[ButtonGroup] Add theme to ButtonGroup and move CSS to Button #2441

dleroux · 2019-11-18T17:48:50Z

WHY are these changes introduced?

addresses part of: https://github.com/Shopify/polaris-ux/issues/382

and also

fixes: #1240

WHAT is this pull request doing?

Keep layout CSS as part of ButtonGroup (essentially margins).
Adds data attributes to ButtonGroup
Moves necessary styles to Button
adds the theme to ButtonGroup

How to 🎩

When this gets into a release, this PR in web will need to be shipped at the same time.

Copy-paste this code in playground/Playground.tsx:

import React, {useState, useCallback} from 'react';
import {Page, ButtonGroup, Button, Popover, ActionList} from '../src';
export function Playground() {
  return (
    <Page title="Playground">
      <ButtonGroup segmented>
        <Button>Bold</Button>
        <Button>Italic</Button>
        <Button>Underline</Button>
        <PopoverWithActionListExample />
      </ButtonGroup>
    </Page>
  );
}
function PopoverWithActionListExample() {
  const [popoverActive, setPopoverActive] = useState(true);
  const togglePopoverActive = useCallback(
    () => setPopoverActive((popoverActive) => !popoverActive),
    [],
  );
  const activator = (
    <Button onClick={togglePopoverActive} disclosure>
      More actions
    </Button>
  );
  return (
    <Popover
      active={popoverActive}
      activator={activator}
      onClose={togglePopoverActive}
    >
      <ActionList items={[{content: 'Import'}, {content: 'Export'}]} />
      <Button>More actions</Button>
    </Popover>
  );
}

Copy-paste this code for the split action button:

import React, {useState, useCallback} from 'react';
import {CaretDownMinor} from '@shopify/polaris-icons';
import {Page, ButtonGroup, Button, Popover, ActionList} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <ButtonGroup segmented>
        <Button primary>Underline</Button>
        <PopoverWithActionListExample />
      </ButtonGroup>
    </Page>
  );
}

function PopoverWithActionListExample() {
  const [popoverActive, setPopoverActive] = useState(true);
  const togglePopoverActive = useCallback(
    () => setPopoverActive((popoverActive) => !popoverActive),
    [],
  );
  const activator = (
    <Button
      pressed={popoverActive}
      primary
      icon={CaretDownMinor}
      onClick={togglePopoverActive}
    />
  );
  return (
    <Popover
      active={popoverActive}
      activator={activator}
      onClose={togglePopoverActive}
    >
      <ActionList items={[{content: 'Import'}, {content: 'Export'}]} />
      <Button>Im still rounded because Portal overwrites my context</Button>
    </Popover>
  );
}

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide
For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

dleroux · 2019-11-18T17:49:45Z

src/components/Button/Button.scss

@@ -53,13 +53,13 @@ $partial-button-filled-pressed-box-shadow: inset 0 0 0 0 transparent,
    transition-duration: duration(fast);
    background: linear-gradient(to bottom, $color-light, $color-light);
    border-color: $color-dark;
-    box-shadow: $partial-button-filled-pressed-box-shadow$color-dark;


Not part of the changed but noticed this while editing the file.

dleroux · 2019-11-18T17:50:36Z

src/components/Button/Button.scss

@@ -71,6 +71,38 @@ $partial-button-filled-pressed-box-shadow: inset 0 0 0 0 transparent,
  }
 }

+.globalTheming.inSegmentedGroup,


Once we remove the .globalTheming these can be safely removed as well. Specificity issue.

github-actions · 2019-11-18T17:50:46Z

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified	9
Files potentially affected	139

Details

All files potentially affected (total: 139)

📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Button/Button.scss (total: 52)

Files potentially affected (total: 52)

🎨 src/components/ButtonGroup/ButtonGroup.scss (total: 17)

Files potentially affected (total: 17)

🧩 src/components/ButtonGroup/ButtonGroup.tsx (total: 16)

Files potentially affected (total: 16)

🧩 src/components/ButtonGroup/components/Item/Item.tsx (total: 17)

Files potentially affected (total: 17)

🧩 src/components/ButtonGroup/components/Item/tests/Item.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/ButtonGroup/tests/ButtonGroup.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/theme/utils.ts (total: 138)

Files potentially affected (total: 138)

📄 yarn.lock (total: 0)

Files potentially affected (total: 0)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

dleroux · 2019-11-18T17:51:27Z

src/components/Button/Button.tsx

@@ -135,6 +139,27 @@ export function Button({

  const i18n = useI18n();

+  const buttonGroupContext = useButtonGroupContext();


Styling logic of the button itself now moved to Button.

dleroux · 2019-11-18T18:48:36Z

src/components/ButtonGroup/components/Item/Item.tsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, {useState} from 'react';


took the opportunity to convert Item to a functional component.

dleroux · 2019-11-19T19:11:26Z

src/components/Portal/Portal.tsx

@@ -67,8 +68,14 @@ export class Portal extends React.PureComponent<PortalProps, State> {
  }

  render() {
+    const childrenMarkup = (
+      <ButtonGroupContext.Provider value={undefined}>


@BPScott I was thinking this could be a valid option. I debated adding this to popover because additional buttons would always be inside a popover, however, new overlays could come at play one day and this will guard against these as well.

Nice trick! I'll forget all about it in a few weeks so it'd be worth adding a comment about why this is here

BPScott · 2019-11-19T23:11:41Z

src/components/Button/Button.tsx

@@ -124,6 +126,7 @@ export function Button({
 }: ButtonProps) {
  const {unstableGlobalTheming = false} = useFeatures();
  const hasGivenDeprecationWarning = useRef(false);
+  const id = useUniqueId('Button', idProp);


Having to add an ID to every button feels rather heavy handed, I wonder if there is a way we can avoid this (or if not, can we make the id needed by the context be distinct from the id attribute that gets added to the DOM).

Perhaps instead of having the Buttons be responsible for adding themselves to the context, instead ButtonGroup could trawl through its children to collect the Button elements and adjust their props?

What do you think of just using the Id internally and not modifying the DOM?

Having ButtonGroup look at its children and add props I think could be done by recursively looping through the children and adding a prop to the Button by using cloneElement. Is that what you have in mind? Doing that would limit our implementation to Buttons. Having Buttons register themselves means this can be added to any component using the registration hook. For instance, the first button in BulkAction isn't a Button per se, but with this approach, we can still make use to the group.

I'd be on board with using the id internally, I think that pollutes the DOM a little less.

As an aside how many renders does this approach trigger? Do we pay a price for rendering the button group, then when rendering the button updating the context (does that cause another render)

Having ButtonGroup look at its children and add props I think could be done by recursively looping through the children and adding a prop to the Button by using cloneElement. Is that what you have in mind? Doing that would limit our implementation to Buttons. Having Buttons register themselves means this can be added to any component using the registration hook.

Something like that yeah, though I'm not sure about its performance characteristics so I don't know if it's a good idea or not. We're changing the registration point from within the child element (e.g. Button) to the container (i.e. ButtonGroup) - we can make that say "look for Buttons and Popovers". We wouldn't be able to account for any component (e.g. something that exists in web) but being able to open that up to ANYTHING can be a child of a ButtonGroup feels a bit too open-ended to me at the moment (though I've not thought about this in depth)

As an aside how many renders does this approach trigger? Do we pay a price for rendering the button group, then when rendering the button updating the context (does that cause another render)

That is a bit of a concern that it renders every time a button renders but the render is negligible I would say because buttons are small and there won't be that many in a group.

BPScott · 2019-11-19T23:17:26Z

src/components/Portal/Portal.tsx

@@ -67,8 +68,14 @@ export class Portal extends React.PureComponent<PortalProps, State> {
  }

  render() {
+    const childrenMarkup = (
+      <ButtonGroupContext.Provider value={undefined}>


Nice trick! I'll forget all about it in a few weeks so it'd be worth adding a comment about why this is here

BPScott · 2019-11-19T23:26:38Z

src/components/ButtonGroup/components/Item/Item.tsx

+  );
+
+  return (
+    <div className={className} onFocus={setFocused} onBlur={setFocused}>


Will this potentially cause oddness if you try and focus something that is already focussed, or blur something that is already blured? (e.g. if it's already focused causing it to focus again will cause it to toggle to the unfocused state instead of remaining focused)

useForcableToggle() and its options for "always set to true" and "always set to false" would be better here.

dleroux · 2019-11-20T13:41:19Z

@chloerice I provide the playground above to confirm that the split button can be done:

dleroux · 2019-11-20T22:25:05Z

Going with Ben's suggestion here and simply moving the selectors to Button using data-attributes.

Using context gets us where we want but the only real advantage is knowing which is the first and last button at the cost of additional renders.

This does allow us to use the data attributes to style whatever component we want to style with round corners. Thanks Ben!

chloerice

This works great, Dan!

🎩 Tophatted with this updated playground code:

import React, {useState, useCallback} from 'react';
import {CaretDownMinor} from '@shopify/polaris-icons';

import {
  Page,
  Select,
  FormLayout,
  TextField,
  ButtonGroup,
  Button,
  Popover,
  ActionList,
  Card,
  Layout,
} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <Layout>
        <Layout.Section>
          <Card title="New button group implementation supports grouping popover buttons">
            <Card.Section title="Segmented button group with disclosure buttons">
              <ButtonGroup segmented>
                <Button>Bold</Button>
                <Button>Italic</Button>
                <Button>Underline</Button>
                <PopoverWithActionListExample />
                <PopoverFormExample />
              </ButtonGroup>
            </Card.Section>
            <Card.Section title="Split button">
              <SplitButtonExample />
            </Card.Section>
            <Card.Section title="Basic button group">
              <ButtonGroup>
                <Button>Bold</Button>
                <Button>Italic</Button>
                <Button>Underline</Button>
                <PopoverWithActionListExample />
                <PopoverFormExample />
              </ButtonGroup>
            </Card.Section>
            <Card.Section title="Inventory quantity input">
              <InventoryQuantityInput />
            </Card.Section>
          </Card>
        </Layout.Section>
        <Layout.Section secondary>
          <Card title="New button group implementation supports grouping popover buttons">
            <Card.Section title="Segmented button group with disclosure buttons">
              <ButtonGroup segmented>
                <Button>Bold</Button>
                <Button>Italic</Button>
                <Button>Underline</Button>
                <PopoverWithActionListExample />
                <PopoverFormExample />
              </ButtonGroup>
            </Card.Section>
            <Card.Section title="Split button">
              <SplitButtonExample />
            </Card.Section>
            <Card.Section title="Basic button group">
              <ButtonGroup>
                <Button>Bold</Button>
                <Button>Italic</Button>
                <Button>Underline</Button>
                <PopoverWithActionListExample />
                <PopoverFormExample />
              </ButtonGroup>
            </Card.Section>
            <Card.Section title="Inventory quantity input">
              <InventoryQuantityInput />
            </Card.Section>
          </Card>
        </Layout.Section>
      </Layout>
    </Page>
  );
}

function PopoverWithActionListExample() {
  const [popoverActive, setPopoverActive] = useState(false);
  const togglePopoverActive = useCallback(
    () => setPopoverActive((popoverActive) => !popoverActive),
    [],
  );
  const activator = (
    <Button onClick={togglePopoverActive} disclosure>
      More actions
    </Button>
  );
  return (
    <Popover
      active={popoverActive}
      activator={activator}
      onClose={togglePopoverActive}
    >
      <ActionList items={[{content: 'Import'}, {content: 'Export'}]} />
    </Popover>
  );
}

function PopoverFormExample() {
  const [popoverActive, setPopoverActive] = useState(false);
  const [tagValue, setTagValue] = useState('');
  const handleTagValueChange = useCallback((value) => setTagValue(value), []);

  const togglePopoverActive = useCallback(
    () => setPopoverActive((popoverActive) => !popoverActive),
    [],
  );

  const activator = (
    <Button onClick={togglePopoverActive} disclosure>
      Filter
    </Button>
  );

  return (
    <Popover
      active={popoverActive}
      activator={activator}
      onClose={togglePopoverActive}
      sectioned
    >
      <FormLayout>
        <Select
          value="Tagged with"
          label="Show all customers where:"
          options={['Tagged with']}
          onChange={() => {}}
        />
        <TextField
          label="Tags"
          value={tagValue}
          onChange={handleTagValueChange}
        />
        <Button size="slim">Add filter</Button>
      </FormLayout>
    </Popover>
  );
}

function SplitButtonExample() {
  const [popoverActive, setPopoverActive] = useState(false);
  const togglePopoverActive = useCallback(
    () => setPopoverActive((popoverActive) => !popoverActive),
    [],
  );
  const activator = (
    <Button
      accessibilityLabel="More save actions"
      primary
      onClick={togglePopoverActive}
      icon={CaretDownMinor}
    />
  );

  return (
    <ButtonGroup segmented>
      <Button primary>Save</Button>
      <Popover
        active={popoverActive}
        activator={activator}
        onClose={togglePopoverActive}
        preferredAlignment="right"
      >
        <ActionList
          items={[{content: 'Save as draft order'}]}
          onActionAnyItem={togglePopoverActive}
        />
      </Popover>
    </ButtonGroup>
  );
}

function InventoryQuantityInput() {
  const [currentOperation, setCurrentOperation] = useState('add');
  const togglePressed = useCallback(
    (operation) => () => {
      setCurrentOperation(operation);
    },
    [],
  );

  const addActive = currentOperation === 'add';
  const toggleButtons = (
    <ButtonGroup segmented>
      <Button onClick={togglePressed('add')} pressed={addActive}>
        Add
      </Button>

      <Button onClick={togglePressed('set')} pressed={!addActive}>
        Set
      </Button>
    </ButtonGroup>
  );

  const primaryButton = (
    <Button disabled primary submit>
      Save
    </Button>
  );

  const inputLabel = addActive ? 'Add' : 'Set';

  return (
    <TextField
      type="number"
      label={inputLabel}
      labelHidden
      connectedLeft={toggleButtons}
      connectedRight={primaryButton}
      onChange={() => {}}
    />
  );
}

One thing I noticed is that segmented button groups break in small spaces, but I think that's an issue with ButtonGroup that pre-exists these changes 🤔

When I tophatted in web, there's a few places that button groups break because they nest the ToggleButton from @shopify/polaris-next, which doesn't have this new CSS that makes this work for Button. But the new pressed boolean prop on the Button does the same thing that ToggleButton does, so we'd just want to either add the same CSS to ToggleButton in @shopify/polaris-next as these changes add to Button or even better just open a PR to update the QuantityInput in web to use Button with pressed.

I also notice that the theming breaks, but I can't tell if it's because button theming is incomplete 🤔

I'll update #2329 to just be adding a split button example to the Button docs using the ButtonGroup 😀

dleroux · 2019-11-25T16:08:04Z

Thank you for such a thorough 🎩@chloerice. That playground 😍

I also notice that the theming breaks, but I can't tell if it's because button theming is incomplete

Are you referring to the icon on primary or was there something else?

The wrapping does occur today, so this is not solved by this PR :(

I also started removing the ToggleButton from polaris-next

dleroux · 2019-11-25T16:12:41Z

yarn.lock

-  version "1.7.8"
-  resolved "https://registry.yarnpkg.com/@shopify/react-testing/-/react-testing-1.7.8.tgz#64b79d8b1cc4791d8e77e3ad5c06dfb7380c88b7"
-  integrity sha512-P4CNcYPjX6OKMe4f6LfyTM0UWlQqinBSoFIWPrWRwAI0qnwKRYnP81WdUANpmeY01SxAIp/WwjKTgpg3sdTnoQ==
+"@shopify/react-testing@^1.8.0":


yarn.lock wasn't committed with #2465

chloerice · 2019-11-25T16:35:40Z

I also started removing the ToggleButton from polaris-next

🎉

I also notice that the theming breaks, but I can't tell if it's because button theming is incomplete

Are you referring to the icon on primary or was there something else?

Yes, the icon on primary, but also the negative margin on segmented button groups seems to disappear 🤔

dleroux · 2019-11-25T16:37:01Z

I've fixed the icon color, but the gap is part of the new design.

Which brings up a good point about the split button. I think it still makes sense but maybe we should check with @jessebc ?

chloerice · 2019-11-25T16:57:31Z

src/components/ButtonGroup/ButtonGroup.scss

+    .Item {
+      // stylelint-disable-next-line selector-max-class, selector-max-specificity
+      &:not(:first-child) {
+        margin-left: spacing(extra-tight);


Looks like we need to add a new variable at the top for this margin value like $segmented-spacing: rem(2px); since spacing(extra-tight) is rem(4px).

Could have sworn this was 4px. I changed it now and was able to remove the .'globalTheming' class.

chloerice · 2019-11-25T16:58:08Z

I've fixed the icon color, but the gap is part of the new design.

Ooohhh okay! Hmmm, I might need to add a split prop to ButtonGroup so folks can 🔥 that gap when implementing a split button.

dleroux · 2019-11-25T20:06:53Z

I've fixed the icon color, but the gap is part of the new design.

Ooohhh okay! Hmmm, I might need to add a split prop to ButtonGroup so folks can 🔥 that gap when implementing a split button.

Now with the smaller gap, I think it looks pretty good. Essentially now the only difference with segmented and non-segmented is that non-segmented keep all their round corners.

dleroux · 2019-11-25T20:16:06Z

tmlayton

🎩 looks good. Are we sure we want buttons in a non-connected group to be that close?

dleroux · 2019-11-26T12:57:21Z

You're right @tmlayton. I looked and this is used in card footers, and such. Removed the adjustments on the regular group. Once this is green I'll ship and get an update in a subsequent PR if need be, so I can continue with my next PR which depends on this one.

@jessebc how is this looking? I kept the same spacing as today on the Basic ButtonGroup cc/ @mirualves @sarahill

clauderic · 2019-11-26T18:19:41Z

🎉

danrosenthal · 2019-11-26T22:08:26Z

This is looking awesome @dleroux, sorry I didn't get around to reviewing before you merged. What do we think about the focus state for these? Should the ring match the shape of the underlying element? I think so.

focus

jessebc · 2019-11-26T22:12:37Z

@jessebc how is this looking? I kept the same spacing as today on the Basic ButtonGroup

I think this is looking very nice. My only question is around the split button. I feel like we should either do a 1px gap on that button, or potentially add a darker line as a visual break instead of the gap.

Should the ring match the shape of the underlying element?
Yes! That'd be great.

dleroux · 2019-11-26T22:23:54Z

@danrosenthal Yes it should match but @tmlayton mentioned we might want to hold off and review
the current solution once we've had a chance to implement it a few times.

@jessebc maybe instead of using ButtonGroup for this we might just have to stick with @chloerice solution of adding a prop to Button. Do you think there'll be other cases where we'd want a smaller gap?

dleroux commented Nov 18, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch 2 times, most recently from 153f21e to 33a878c Compare November 18, 2019 18:24

dleroux requested a review from BPScott November 18, 2019 18:43

dleroux commented Nov 18, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch 5 times, most recently from 1ad62cd to d13d87d Compare November 19, 2019 19:04

dleroux changed the title ~~[WIP] [ButtonGroup] Convert to useContext and add Color System~~ [ButtonGroup] Convert to useContext and add Color System Nov 19, 2019

dleroux requested a review from chloerice November 19, 2019 19:08

dleroux commented Nov 19, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch 2 times, most recently from 15d8694 to e7e3367 Compare November 19, 2019 19:50

This was referenced Nov 19, 2019

[ButtonGroup] Applying design language #2432

Closed

[Button] add support for split disclosure button #2329

Merged

dleroux requested a review from kyledurand November 19, 2019 21:50

BPScott reviewed Nov 19, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch from e7e3367 to cff14e1 Compare November 20, 2019 13:03

dleroux requested a review from tmlayton November 20, 2019 13:05

dleroux force-pushed the buttongroup-context branch from cff14e1 to d03c6ca Compare November 20, 2019 13:20

dleroux requested a review from BPScott November 20, 2019 13:24

dleroux force-pushed the buttongroup-context branch from d03c6ca to 7ff1a54 Compare November 20, 2019 13:31

dleroux force-pushed the buttongroup-context branch from 7ff1a54 to f0d929b Compare November 20, 2019 13:45

dleroux force-pushed the buttongroup-context branch 2 times, most recently from 6da3e8f to fed5e46 Compare November 21, 2019 14:33

dleroux requested a review from AndrewMusgrave November 21, 2019 19:06

chloerice approved these changes Nov 22, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch from fed5e46 to 09000bd Compare November 25, 2019 13:23

dleroux commented Nov 25, 2019

View reviewed changes

chloerice reviewed Nov 25, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch from 533186e to 5185a0a Compare November 25, 2019 20:26

dleroux mentioned this pull request Nov 25, 2019

[BulkActions] Add theming to BulkAction and remove custom ButtonGroup from ResourceList #2467

Merged

6 tasks

tmlayton requested a review from danrosenthal November 26, 2019 08:25

tmlayton approved these changes Nov 26, 2019

View reviewed changes

dleroux force-pushed the buttongroup-context branch from 289255e to 337cccd Compare November 26, 2019 12:50

dleroux added 2 commits November 26, 2019 07:51

Update to button group css

f122b39

update spacing

12714f4

dleroux force-pushed the buttongroup-context branch from 337cccd to 12714f4 Compare November 26, 2019 12:52

dleroux merged commit a1a6c71 into master Nov 26, 2019

dleroux temporarily deployed to production December 4, 2019 14:42 Inactive

alex-page deleted the buttongroup-context branch November 10, 2020 00:51

		@@ -135,6 +139,27 @@ export function Button({

		const i18n = useI18n();

		const buttonGroupContext = useButtonGroupContext();

		@@ -1,4 +1,4 @@
		import React from 'react';
		import React, {useState} from 'react';

[ButtonGroup] Add theme to ButtonGroup and move CSS to Button #2441

[ButtonGroup] Add theme to ButtonGroup and move CSS to Button #2441

Conversation

dleroux commented Nov 18, 2019 • edited Loading

WHY are these changes introduced?

WHAT is this pull request doing?

How to 🎩

🎩 checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2019 • edited Loading

Details

Files potentially affected (total: 0)

Files potentially affected (total: 52)

Files potentially affected (total: 17)

Files potentially affected (total: 16)

Files potentially affected (total: 17)

Files potentially affected (total: 0)

Files potentially affected (total: 0)

Files potentially affected (total: 138)

Files potentially affected (total: 0)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dleroux Nov 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dleroux commented Nov 20, 2019

dleroux commented Nov 20, 2019

chloerice left a comment • edited Loading

Choose a reason for hiding this comment

dleroux commented Nov 25, 2019

Choose a reason for hiding this comment

chloerice commented Nov 25, 2019

dleroux commented Nov 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chloerice commented Nov 25, 2019

dleroux commented Nov 25, 2019

dleroux commented Nov 25, 2019

tmlayton left a comment

Choose a reason for hiding this comment

dleroux commented Nov 26, 2019 • edited Loading

clauderic commented Nov 26, 2019

danrosenthal commented Nov 26, 2019

jessebc commented Nov 26, 2019

dleroux commented Nov 26, 2019 • edited Loading

dleroux commented Nov 18, 2019 •

edited

Loading

github-actions bot commented Nov 18, 2019 •

edited

Loading

dleroux Nov 20, 2019 •

edited

Loading

chloerice left a comment •

edited

Loading

dleroux commented Nov 25, 2019 •

edited

Loading

dleroux commented Nov 26, 2019 •

edited

Loading

dleroux commented Nov 26, 2019 •

edited

Loading