Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Color System] Apply CS to Indicator component #2429

Merged
merged 2 commits into from
Nov 20, 2019
Merged

[Color System] Apply CS to Indicator component #2429

merged 2 commits into from
Nov 20, 2019

Conversation

dleroux
Copy link
Contributor

@dleroux dleroux commented Nov 13, 2019

WHY are these changes introduced?

addresses: https://github.com/Shopify/polaris-ux/issues/349

WHAT is this pull request doing?

Paired with Miru apply CS to Indicator component:

Screen Shot 2019-11-13 at 2 20 12 PM
Screen Shot 2019-11-13 at 2 20 04 PM

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React, {useState, useCallback} from 'react';
import {
  HomeMajorMonotone,
  ProductsMajorTwotone,
  OrdersMajorTwotone,
  OnlineStoreMajorTwotone,
  CirclePlusOutlineMinor,
} from '@shopify/polaris-icons';
import {
  Page,
  Breadcrumbs,
  ResourceItem,
  TextStyle,
  Avatar,
  Card,
  ResourceList,
  Indicator,
  Navigation,
} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <Navigation location="/">
        <Navigation.Section
          items={[
            {
              label: 'Home',
              icon: HomeMajorMonotone,
              subNavigationItems: [
                {
                  label: 'sub label',
                  url: '/other',
                  new: true,
                },
              ],
            },
            {
              url: '/path/to/place',
              label: 'Orders',
              icon: OrdersMajorTwotone,
            },
            {
              url: '/path/to/place',
              label: 'Products',
              icon: ProductsMajorTwotone,
            },
          ]}
        />
        <Navigation.Section
          title="Sales channels"
          items={[
            {
              url: '/path/to/place',
              label: 'Online Store',
              icon: OnlineStoreMajorTwotone,
            },
          ]}
          action={{
            accessibilityLabel: 'Add sales channel',
            icon: CirclePlusOutlineMinor,
            onClick: () => {},
          }}
        />
      </Navigation>
    </Page>
  );
}

🎩 checklist

@dleroux dleroux added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Nov 13, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2019

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified1
Files potentially affected4

Details

All files potentially affected (total: 4)
🎨 src/components/Indicator/Indicator.scss (total: 4)

Files potentially affected (total: 4)


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@dleroux dleroux requested a review from tmlayton November 19, 2019 19:51
@dleroux dleroux merged commit 35d61d2 into master Nov 20, 2019
@dleroux dleroux deleted the cs-indicator branch November 20, 2019 11:45
@dleroux dleroux temporarily deployed to production December 4, 2019 14:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants