[v11.16.0] Update next branch with changes from main
#10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing quite a bit of output in build scripts. Adding a width and height to an icon then running yarn optimize confirms that this still works
### WHY are these changes introduced? Fixes Shopify/polaris-internal#1049 Because `<Modal />` wraps the `activator` in a `<Box />`, it is not possible to style elements inline. The `<Box />` can be removed as it is only used for passing the ref along, which we can pass to the activator instead with `React.cloneElement`. ### WHAT is this pull request doing? <details> <summary>1. Modal activator is no longer wrapped in a Box</summary> BEFORE: ```jsx <div class="Polaris-Box"> <button class="Polaris-Button" type="button"> <span class="Polaris-Button__Content"> <span class="Polaris-Button__Text">Click Me</span> </span> </button> </div> ``` AFTER: ```jsx <button class="Polaris-Button" type="button"> <span class="Polaris-Button__Content"> <span class="Polaris-Button__Text">Click Me</span> </span> </button> ``` </details> 2. The `ref` is attached to the `activator` instead of the box which used to wrap the `activator`. ### 🎩 checklist - [X] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [X] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [X] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [X] Updated the component's `README.md` with documentation changes - [X] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Bumps [fastify](https://github.com/fastify/fastify) from 4.5.3 to 4.15.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/fastify/fastify/releases">fastify's releases</a>.</em></p> <blockquote> <h2>v4.15.0</h2> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump tsd from 0.25.0 to 0.26.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4614">fastify/fastify#4614</a></li> <li>feat: use internal trees for prettyPrint by <a href="https://github.com/ivan-tymoshenko"><code>@ivan-tymoshenko</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4618">fastify/fastify#4618</a></li> <li>docs: add metcoder95 as collaborator by <a href="https://github.com/metcoder95"><code>@metcoder95</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4622">fastify/fastify#4622</a></li> <li>build(deps): bump lycheeverse/lychee-action from 1.5.4 to 1.6.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4603">fastify/fastify#4603</a></li> <li>Logger validator throws by <a href="https://github.com/victortosts"><code>@victortosts</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4520">fastify/fastify#4520</a></li> <li>feat: expose prettyPrint method param by <a href="https://github.com/ivan-tymoshenko"><code>@ivan-tymoshenko</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4623">fastify/fastify#4623</a></li> <li>ensure that generated validators are up to date by <a href="https://github.com/Uzlopak"><code>@Uzlopak</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4508">fastify/fastify#4508</a></li> <li>fix: check if validation schema is undefined by <a href="https://github.com/Eomm"><code>@Eomm</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4620">fastify/fastify#4620</a></li> <li>fix: content-type mis-handling for invalid non-essence content-type by <a href="https://github.com/climba03003"><code>@climba03003</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4509">fastify/fastify#4509</a></li> <li>Bump version of fast-json-stringify-compiler by <a href="https://github.com/Uzlopak"><code>@Uzlopak</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4630">fastify/fastify#4630</a></li> <li>fix: avoid invoking onError hook when aborted handler resolves by <a href="https://github.com/meyfa"><code>@meyfa</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4631">fastify/fastify#4631</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/victortosts"><code>@victortosts</code></a> made their first contribution in <a href="https://redirect.github.com/fastify/fastify/pull/4520">fastify/fastify#4520</a></li> <li><a href="https://github.com/meyfa"><code>@meyfa</code></a> made their first contribution in <a href="https://redirect.github.com/fastify/fastify/pull/4631">fastify/fastify#4631</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/fastify/fastify/compare/v4.14.1...v4.15.0">https://github.com/fastify/fastify/compare/v4.14.1...v4.15.0</a></p> <h2>v4.14.1</h2> <h2>What's Changed</h2> <ul> <li>chore(.gitignore): add bun lockfile by <a href="https://github.com/Fdawgs"><code>@Fdawgs</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4609">fastify/fastify#4609</a></li> <li>docs: consistency fix on note and example for frameworkErrors by <a href="https://github.com/nadhifikbarw"><code>@nadhifikbarw</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4610">fastify/fastify#4610</a></li> <li>fix: onRequestAbort hook request pending by <a href="https://github.com/Eomm"><code>@Eomm</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4611">fastify/fastify#4611</a></li> <li>refactor: cleanup duplicated symbols by <a href="https://github.com/metcoder95"><code>@metcoder95</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4612">fastify/fastify#4612</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/nadhifikbarw"><code>@nadhifikbarw</code></a> made their first contribution in <a href="https://redirect.github.com/fastify/fastify/pull/4610">fastify/fastify#4610</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/fastify/fastify/compare/v4.14.0...v4.14.1">https://github.com/fastify/fastify/compare/v4.14.0...v4.14.1</a></p> <h2>v4.14.0</h2> <h2>What's Changed</h2> <ul> <li>Schema error formatter type by <a href="https://github.com/cm-ayf"><code>@cm-ayf</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4570">fastify/fastify#4570</a></li> <li>Fix typescript integration bug with ajv-compiler by <a href="https://github.com/Uzlopak"><code>@Uzlopak</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4555">fastify/fastify#4555</a></li> <li>build(deps-dev): bump yup from 0.32.11 to 1.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4581">fastify/fastify#4581</a></li> <li>feat: Add onRequestAbort hook. by <a href="https://github.com/ShogunPanda"><code>@ShogunPanda</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4582">fastify/fastify#4582</a></li> <li>ci(package-manager): update ubuntu os to latest by <a href="https://github.com/Fdawgs"><code>@Fdawgs</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4591">fastify/fastify#4591</a></li> <li>Improve Contribution Guide's VSCode setup instructions by <a href="https://github.com/evpirnia"><code>@evpirnia</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4594">fastify/fastify#4594</a></li> <li>fix: Only remove implicit HEAD routes. by <a href="https://github.com/ShogunPanda"><code>@ShogunPanda</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4596">fastify/fastify#4596</a></li> <li>Fix tests in Node.js v16 by <a href="https://github.com/mcollina"><code>@mcollina</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4597">fastify/fastify#4597</a></li> <li>docs(ecosystem): add fastify-flux tool by <a href="https://github.com/Jnig"><code>@Jnig</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4599">fastify/fastify#4599</a></li> <li>feat: include origin error message into serialization error by <a href="https://github.com/ivan-tymoshenko"><code>@ivan-tymoshenko</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4601">fastify/fastify#4601</a></li> <li>feat: log requests refused before processing starts by <a href="https://github.com/airhorns"><code>@airhorns</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4600">fastify/fastify#4600</a></li> <li>fix: add missed symbol by <a href="https://github.com/metcoder95"><code>@metcoder95</code></a> in <a href="https://redirect.github.com/fastify/fastify/pull/4608">fastify/fastify#4608</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/evpirnia"><code>@evpirnia</code></a> made their first contribution in <a href="https://redirect.github.com/fastify/fastify/pull/4594">fastify/fastify#4594</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/fastify/fastify/commit/87b644087c5b15bd70766bc4efeb940308d97066"><code>87b6440</code></a> Bumped v4.15.0</li> <li><a href="https://github.com/fastify/fastify/commit/da9ace5ef2f5828bc71a2e54af9fdc4107e1258d"><code>da9ace5</code></a> fix: avoid invoking onError hook when aborted handler resolves (<a href="https://redirect.github.com/fastify/fastify/issues/4631">#4631</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/ca9785a3fadd9050ec163c6a0841a06f387a71c6"><code>ca9785a</code></a> Bump version of fast-json-stringify-compiler (<a href="https://redirect.github.com/fastify/fastify/issues/4630">#4630</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/4723c1b228f4a3d9e0ba38a137084b7fa2b622db"><code>4723c1b</code></a> fix: content-type mis-handling for invalid non-essence content-type (<a href="https://redirect.github.com/fastify/fastify/issues/4509">#4509</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/6b5957d0a766b3fc4c8926b9683ae956fc888edf"><code>6b5957d</code></a> fix: check if validation schema is undefined (<a href="https://redirect.github.com/fastify/fastify/issues/4620">#4620</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/71abc48379d37acc217246b318b40b01920b95e1"><code>71abc48</code></a> ensure that generated validators are up to date (<a href="https://redirect.github.com/fastify/fastify/issues/4508">#4508</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/b69ae0f8549900d1a127f003501f0cc0eedcadd3"><code>b69ae0f</code></a> feat: expose prettyPrint method param (<a href="https://redirect.github.com/fastify/fastify/issues/4623">#4623</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/9e92e4f3838794c1d4a6b51f46d835e74460bb85"><code>9e92e4f</code></a> fix: logger validator throws (<a href="https://redirect.github.com/fastify/fastify/issues/4520">#4520</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/2ba790f86c89d0885e441d8a5838ff8abb00696f"><code>2ba790f</code></a> build(deps): bump lycheeverse/lychee-action from 1.5.4 to 1.6.1 (<a href="https://redirect.github.com/fastify/fastify/issues/4603">#4603</a>)</li> <li><a href="https://github.com/fastify/fastify/commit/8e75c50a2fd14fa831c703924ec720d06fe6abe9"><code>8e75c50</code></a> docs: add metcoder95 as collaborator (<a href="https://redirect.github.com/fastify/fastify/issues/4622">#4622</a>)</li> <li>Additional commits viewable in <a href="https://github.com/fastify/fastify/compare/v4.5.3...v4.15.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.72.0 to 5.76.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p> <blockquote> <h2>v5.76.0</h2> <h2>Bugfixes</h2> <ul> <li>Avoid cross-realm object access by <a href="https://github.com/Jack-Works"><code>@Jack-Works</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16500">webpack/webpack#16500</a></li> <li>Improve hash performance via conditional initialization by <a href="https://github.com/lvivski"><code>@lvivski</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16491">webpack/webpack#16491</a></li> <li>Serialize <code>generatedCode</code> info to fix bug in asset module cache restoration by <a href="https://github.com/ryanwilsonperkin"><code>@ryanwilsonperkin</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16703">webpack/webpack#16703</a></li> <li>Improve performance of <code>hashRegExp</code> lookup by <a href="https://github.com/ryanwilsonperkin"><code>@ryanwilsonperkin</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16759">webpack/webpack#16759</a></li> </ul> <h2>Features</h2> <ul> <li>add <code>target</code> to <code>LoaderContext</code> type by <a href="https://github.com/askoufis"><code>@askoufis</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16781">webpack/webpack#16781</a></li> </ul> <h2>Security</h2> <ul> <li><a href="https://github.com/advisories/GHSA-3rfm-jhwj-7488">CVE-2022-37603</a> fixed by <a href="https://github.com/akhilgkrishnan"><code>@akhilgkrishnan</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16446">webpack/webpack#16446</a></li> </ul> <h2>Repo Changes</h2> <ul> <li>Fix HTML5 logo in README by <a href="https://github.com/jakebailey"><code>@jakebailey</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16614">webpack/webpack#16614</a></li> <li>Replace TypeScript logo in README by <a href="https://github.com/jakebailey"><code>@jakebailey</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16613">webpack/webpack#16613</a></li> <li>Update actions/cache dependencies by <a href="https://github.com/piwysocki"><code>@piwysocki</code></a> in <a href="https://redirect.github.com/webpack/webpack/pull/16493">webpack/webpack#16493</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Jack-Works"><code>@Jack-Works</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16500">webpack/webpack#16500</a></li> <li><a href="https://github.com/lvivski"><code>@lvivski</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16491">webpack/webpack#16491</a></li> <li><a href="https://github.com/jakebailey"><code>@jakebailey</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16614">webpack/webpack#16614</a></li> <li><a href="https://github.com/akhilgkrishnan"><code>@akhilgkrishnan</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16446">webpack/webpack#16446</a></li> <li><a href="https://github.com/ryanwilsonperkin"><code>@ryanwilsonperkin</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16703">webpack/webpack#16703</a></li> <li><a href="https://github.com/piwysocki"><code>@piwysocki</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16493">webpack/webpack#16493</a></li> <li><a href="https://github.com/askoufis"><code>@askoufis</code></a> made their first contribution in <a href="https://redirect.github.com/webpack/webpack/pull/16781">webpack/webpack#16781</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0">https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0</a></p> <h2>v5.75.0</h2> <h1>Bugfixes</h1> <ul> <li><code>experiments.*</code> normalize to <code>false</code> when opt-out</li> <li>avoid <code>NaN%</code></li> <li>show the correct error when using a conflicting chunk name in code</li> <li>HMR code tests existance of <code>window</code> before trying to access it</li> <li>fix <code>eval-nosources-*</code> actually exclude sources</li> <li>fix race condition where no module is returned from processing module</li> <li>fix position of standalong semicolon in runtime code</li> </ul> <h1>Features</h1> <ul> <li>add support for <code>@import</code> to extenal CSS when using experimental CSS in node</li> <li>add <code>i64</code> support to the deprecated WASM implementation</li> </ul> <h1>Developer Experience</h1> <ul> <li>expose <code>EnableWasmLoadingPlugin</code></li> <li>add more typings</li> <li>generate getters instead of readonly properties in typings to allow overriding them</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/webpack/webpack/commit/97b1718720c33f1b17302a74c5284b01e02ec001"><code>97b1718</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16781">#16781</a> from askoufis/loader-context-target-type</li> <li><a href="https://github.com/webpack/webpack/commit/b84efe6224b276bf72e4c5e2f4e76acddfaeef07"><code>b84efe6</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16759">#16759</a> from ryanwilsonperkin/real-content-hash-regex-perf</li> <li><a href="https://github.com/webpack/webpack/commit/c98e9e001441b165c7ed4845700839730b505833"><code>c98e9e0</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16493">#16493</a> from piwysocki/patch-1</li> <li><a href="https://github.com/webpack/webpack/commit/5f34acfbc074da6cc09f48944d7f2b4273ffb3f8"><code>5f34acf</code></a> feat: Add <code>target</code> to <code>LoaderContext</code> type</li> <li><a href="https://github.com/webpack/webpack/commit/b7fc4d876deb958d7ee81ecc00a312e39a354a44"><code>b7fc4d8</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16703">#16703</a> from ryanwilsonperkin/ryanwilsonperkin/fix-16160</li> <li><a href="https://github.com/webpack/webpack/commit/63ea82da4d4e4242b6a6285fc937f0684f264fe8"><code>63ea82d</code></a> Merge branch 'webpack:main' into patch-1</li> <li><a href="https://github.com/webpack/webpack/commit/4ba225225b1348c8776ca5b5fe53468519413bc0"><code>4ba2252</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16446">#16446</a> from akhilgkrishnan/patch-1</li> <li><a href="https://github.com/webpack/webpack/commit/1acd6350be3d74d4ac70b64cbbc60f27724b618b"><code>1acd635</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16613">#16613</a> from jakebailey/ts-logo</li> <li><a href="https://github.com/webpack/webpack/commit/302eb37fe19ed7ca60eaf895aca4f9da9dfd7931"><code>302eb37</code></a> Merge pull request <a href="https://redirect.github.com/webpack/webpack/issues/16614">#16614</a> from jakebailey/html5-logo</li> <li><a href="https://github.com/webpack/webpack/commit/cfdb1dfe59b33bf7441b8a8e4fc58d75e4f54cee"><code>cfdb1df</code></a> Improve performance of hashRegExp lookup</li> <li>Additional commits viewable in <a href="https://github.com/webpack/webpack/compare/v5.72.0...v5.76.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~evilebottnawi">evilebottnawi</a>, a new releaser for webpack since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/SamVerschueren/decode-uri-component/releases">decode-uri-component's releases</a>.</em></p> <blockquote> <h2>v0.2.2</h2> <ul> <li>Prevent overwriting previously decoded tokens 980e0bf</li> </ul> <p><a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2">https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2</a></p> <h2>v0.2.1</h2> <ul> <li>Switch to GitHub workflows 76abc93</li> <li>Fix issue where decode throws - fixes <a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/6">#6</a> 746ca5d</li> <li>Update license (<a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/1">#1</a>) 486d7e2</li> <li>Tidelift tasks a650457</li> <li>Meta tweaks 66e1c28</li> </ul> <p><a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1">https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/a0eea469d26eb0df668b081672cdb9581feb78eb"><code>a0eea46</code></a> 0.2.2</li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/980e0bf09b64d94f1aa79012f895816c30ffd152"><code>980e0bf</code></a> Prevent overwriting previously decoded tokens</li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/3c8a373dd4837e89b3f970e01295dd03e1405a33"><code>3c8a373</code></a> 0.2.1</li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/76abc939783fe3900fadb7d384a74d324d5557f3"><code>76abc93</code></a> Switch to GitHub workflows</li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/746ca5dcb6667c5d364e782d53c542830e4c10b9"><code>746ca5d</code></a> Fix issue where decode throws - fixes <a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/6">#6</a></li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/486d7e26d3a8c0fbe860fb651fe1bc98c2f2be30"><code>486d7e2</code></a> Update license (<a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/1">#1</a>)</li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/a65045724e6234acef87f31da499d4807b20b134"><code>a650457</code></a> Tidelift tasks</li> <li><a href="https://github.com/SamVerschueren/decode-uri-component/commit/66e1c2834c0e189201cb65196ec3101372459b02"><code>66e1c28</code></a> Meta tweaks</li> <li>See full diff in <a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [deep-object-diff](https://github.com/mattphillips/deep-object-diff) from 1.1.7 to 1.1.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mattphillips/deep-object-diff/releases">deep-object-diff's releases</a>.</em></p> <blockquote> <h2>v1.1.9</h2> <h2>Vulnerability patch</h2> <p>Details outlined here: <a href="https://github-redirect.dependabot.com/mattphillips/deep-object-diff/issues/85">#85</a>. TLDR: The prototype of the returned diff object could be polluted but not globally on all objects.</p> <p>Fix: <a href="https://github-redirect.dependabot.com/mattphillips/deep-object-diff/pull/87">mattphillips/deep-object-diff#87</a></p> <p>Thanks <a href="https://github.com/Retr02332"><code>@Retr02332</code></a> for highlighting the issue and validating the fix.</p> <p>This vulnerability was introduced in <a href="https://github.com/mattphillips/deep-object-diff/releases/tag/v1.1.6">https://github.com/mattphillips/deep-object-diff/releases/tag/v1.1.6</a></p> <h2>v1.1.8</h2> <h2>Patch</h2> <ul> <li>Fix typings resolution when using TypeScript 4.7+ with ESM <a href="https://github-redirect.dependabot.com/mattphillips/deep-object-diff/issues/83">#83</a></li> <li>improve return type for detailedDiff <a href="https://github-redirect.dependabot.com/mattphillips/deep-object-diff/issues/72">#72</a></li> </ul> <h2>Credits</h2> <p>Thanks <a href="https://github.com/Nitive"><code>@Nitive</code></a> and <a href="https://github.com/icholy"><code>@icholy</code></a> for your PRs</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/mattphillips/deep-object-diff/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/loader-utils/releases">loader-utils's releases</a>.</em></p> <blockquote> <h2>v1.4.2</h2> <h3><a href="https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2">1.4.2</a> (2022-11-11)</h3> <h3>Bug Fixes</h3> <ul> <li>ReDoS problem (<a href="https://github-redirect.dependabot.com/webpack/loader-utils/issues/226">#226</a>) (<a href="https://github.com/webpack/loader-utils/commit/17cbf8fa8989c1cb45bdd2997aa524729475f1fa">17cbf8f</a>)</li> </ul> <h2>v1.4.1</h2> <h3><a href="https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.1">1.4.1</a> (2022-11-07)</h3> <h3>Bug Fixes</h3> <ul> <li>security problem (<a href="https://github-redirect.dependabot.com/webpack/loader-utils/issues/220">#220</a>) (<a href="https://github.com/webpack/loader-utils/commit/4504e34c4796a5836ef70458327351675aed48a5">4504e34</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md">loader-utils's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2">1.4.2</a> (2022-11-11)</h3> <h3>Bug Fixes</h3> <ul> <li>ReDoS problem (<a href="https://github-redirect.dependabot.com/webpack/loader-utils/issues/226">#226</a>) (<a href="https://github.com/webpack/loader-utils/commit/17cbf8fa8989c1cb45bdd2997aa524729475f1fa">17cbf8f</a>)</li> </ul> <h3><a href="https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.1">1.4.1</a> (2022-11-07)</h3> <h3>Bug Fixes</h3> <ul> <li>security problem (<a href="https://github-redirect.dependabot.com/webpack/loader-utils/issues/220">#220</a>) (<a href="https://github.com/webpack/loader-utils/commit/4504e34c4796a5836ef70458327351675aed48a5">4504e34</a>)</li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/webpack/loader-utils/commit/331ad5067d9a1a7b8d646692e6959639969210d1"><code>331ad50</code></a> chore(release): 1.4.2</li> <li><a href="https://github.com/webpack/loader-utils/commit/17cbf8fa8989c1cb45bdd2997aa524729475f1fa"><code>17cbf8f</code></a> fix: ReDoS problem (<a href="https://github-redirect.dependabot.com/webpack/loader-utils/issues/226">#226</a>)</li> <li><a href="https://github.com/webpack/loader-utils/commit/8f082b39f6903929f30fe29dab34f4d9c7ef070a"><code>8f082b3</code></a> chore(release): 1.4.1</li> <li><a href="https://github.com/webpack/loader-utils/commit/4504e34c4796a5836ef70458327351675aed48a5"><code>4504e34</code></a> fix: security problem (<a href="https://github-redirect.dependabot.com/webpack/loader-utils/issues/220">#220</a>)</li> <li>See full diff in <a href="https://github.com/webpack/loader-utils/compare/v1.4.0...v1.4.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Shopify/polaris/network/alerts). </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Use only the `@shopify/polaris-migrator` package. This also removes the documentation for the Polaris CLI on the [Tools page](https://polaris.shopify.com/tools/polaris-cli). Removing these packages will * **Improve our CI times** by removing extra packages from our build, test, and lint workflows * **Reduce confusion** on where to add new migrations or update previous migrations * **Clean up things** such as ESLint configs, changelog entries on Version Package PRs, and package dep bumps
Closes #10084 First pass at allowing prop values to be changed through migrations. Also needed to allow support for finding compound components in the rename prop migration **Question** Should this be merged into main? Or left in next until it's tested?
Fix the broken sandbox landing page Should now redirect to https://polaris.shopify.com/sandbox?code=N4Igxg9gJgpiBcIA8AZGBzAhmAngYUwCcoAdAOwAIKBnGSMqInAMQggBcZCBBMdgSwhlqAXmABtYBXqcy7eBRIgAIv2oBbNdSUUAvgF1d5KgAdC-dU1YcuvAULFSZMOQqUBRAB4mIhdhQAlGB8-HV0jMgA%2BYwpUDGx8IigAOgAJGExYQhiqbHthMXEcqgpgYpLpIVl5RRAAFQ5MABsKAGVmmG0QABpyvV7KEsNigXYmmBEldvGumOjBqiQABQgfADcuPrz%2BDbEAM2baCIrcvh3Mdl8xPsWAIQBXdkvKKDUwJohqe8IYChMmzD8KI3EoANX4MAA7m0OtoFickAB6B5PITzE56PpCPAfWhiAAUAEoKCJIqVwsV0Qi7IIyCg1OwQfxOOpRBInFUXDUlABxQifagwmZhbqlSpyLluEAAORg-mmnTCw3hVERVMWiJW6y4VKRaCwuAIxDSGSyuv1CSNKVadHy6tidRgnnYeCqgLIOr6AE0IPdpJhKPdaDRYRQfiF2ILLjQYL8gXtfJZ8hRMAAjX3%2BHC%2BwjSIOXdRcaiATAIscRCxRU5haFAKEJpOZOOZMDR7mAABYpwXUUMQDY5gQF0WpnDSNsBj1NUW%2BCs4PrUdiYPZ7ZLFJGO52uuTuz2DPXxQ1JZI2s5omJxA2JY3H5OjcaTeqNFoKwW3H6YADWUAgkLISntSCCahszAGB6XnPofiA74QOlTAC0cGggXQe4AUIKVu3GJRRX%2Bb5mnQ2EwmOE5mRgVlChBMoVRODDOilAB5MtCC6AYMQqODfVcWoAFVWmUAASAAGZIBIErCQSob4milABiMSqKoXQWNYyjWJKGjqClIJ2G%2BYQ5NU3J1A47kQAAWh4-iACYAFYhJEvT9MkmT7IxRS%2BmVDEfgYLgAEkWQJEj1GJUlShBeh5zFdTRXY%2B45FFSS9BJCgAoAbhBH5tMISh8XE2JAOA0CGWSXzSJyqh%2BCgMR1OSS4UAgMAOlqyEuAIWgiSI-SKEksRJPa-TsBA6hqH4VN%2BCaZkcBQNMYCaMQAANwShIVOgoBMcz44B1N0WbetU7ExrAd8CSCskwogcZkg%2BdBsvAfb3xgGsAqwpKWUJHaTntVTzwSVoFwOj79K%2B3Afuwd8ipZFbRqaSINthXQ9wvYGDrB0j-s%2Bi0gd%2B0HivUaHorkOHEXRnBEaxllUYRQn92JzHyY1PLoIK%2BdkZxkFCVSqiKXhNUz0pi8rSPW1aXNKn%2BevWkKFvCYlGUDIzjWC57rDYJfEjHQvlTKB7nu-8wPYf7UEK7HIiWTAs0eag9UNsm%2BgNpmjYaBcn1DW4RzwMcyAnS27et%2BEvb1nmidFwXT13QPDzFutJfvaUbD-Vd1xdN0gR3DE6jbX51KViNBSIX5MHl0a03GWsyCaEd%2BD2CgzZzedfDjQVI-Tto21WCvZyo-4A1rHM234dB08IFdfcRBPNwXZPCF1XnLXD4PgTIeGZ%2BIeYehAdh04LagEHEEAPnq8Z4BcEB9G6EBIXK9et-gcRDCAA ### WHY are these changes introduced? Fixes #0000 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Kyle Durand <[email protected]>
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Part of #10126
### WHY are these changes introduced? Fixes a bug with how the migration resolution path is created ### WHAT is this pull request doing? This update resolves migrations from `<migration-name>/transform.js` Co-authored-by: Aaron Casanova <[email protected]>
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Currently Webviews & Mobile Web in iOS don't respect the users preference for Font Scale which is quite inaccessible. <!-- Context about the problem that’s being addressed. --> This PR introduces the use of font: -apple-system-body if it is supported. Inspired by this [dev.to article](https://dev.to/colingourlay/how-to-support-apple-s-dynamic-text-in-your-web-content-with-css-40c0#:~:text=If%20you've%20never%20seen,apple%2Dsystem%2Dbody%20) ### WHAT is this pull request doing? <details> <summary>Before</summary> <img src="https://github.com/Shopify/polaris/assets/703938/f1adb621-2982-4cc0-8946-bd5403e2a558" width="300"/> </details> <details> <summary>After</summary> <img src="https://github.com/Shopify/polaris/assets/703938/a213b56e-80ba-4fca-b09a-226ec2f6bec2" width="300"/> </details> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 1. Open iOS simulator 2. Open Safari within the iOS Simulator 3. Open polaris storybook using this url https://5d559397bae39100201eedc1-krdvxqhrcy.chromatic.com/?path=/story/all-components-text--variants 4. Change Fontscale in `Settings > Accessibility > Display & Text Size > Larger Text ` (using the slider at the bottom) 5. Switch back to Safari 6. Verify the font scale has updated to match the preference in accessibility ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#10101](#10101) [`e6a2d352a`](e6a2d35) Thanks [@samrose3](https://github.com/samrose3)! - Removed the `@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor of using only the `@shopify/polaris-migrator`. Removing these packages will provide the following benefits: - Improve CI time by removing extra packages from our build, test, and lint workflows - Reduce confusion on where to add new migrations or update previous migrations - Clean up ESLint configs, reduce changelog entries, and remove package dependencies - [#10071](#10071) [`23c1391aa`](23c1391) Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for compound components and adding new prop values in the react-rename-component-prop migration ## @shopify/[email protected] ### Minor Changes - [#10086](#10086) [`5a5b3795a`](5a5b379) Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal] Activator no longer wrapped in Box - [#10183](#10183) [`7891c7ed9`](7891c7e) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate connectedDisclosure prop on button - [#10181](#10181) [`219be15aa`](219be15) Thanks [@ssetem](https://github.com/ssetem)! - Added support for [Dynamic Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically) in iOS ### Patch Changes - [#10056](#10056) [`5ecaafc2b`](5ecaafc) Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList] Remove layout jank when bulk actions enabled and item selected - [`bc1f4aab1`](bc1f4aa) Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding margin of Tooltip to allow for interaction with nearby UI elements. ## [email protected] ### Patch Changes - [#10186](#10186) [`b340df129`](b340df1) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed landing page for sandbox - Updated dependencies \[[`5a5b3795a`](5a5b379), [`7891c7ed9`](7891c7e), [`5ecaafc2b`](5ecaafc), [`bc1f4aab1`](bc1f4aa), [`219be15aa`](219be15)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closes #8686 ## Why? With extension GA comes a lot of potential new items in the `More Actions` of pages supporting extensibility making it increasingly more difficult for merchants to find what they are looking for. The median number of links in "More action" menus on the products, orders, and customers pages for high GMV merchants is already between 12 and 31. This number does not count any non-app actions that have been added, so in reality, the number of actions is even higher. This is a terrible UX for our merchants. ## Proposed Changes Adding a search input that will appear anytime an ActionList has more than 10 elements. <img width="1015" alt="Screenshot 2023-08-09 at 9 06 13 AM" src="https://github.com/Shopify/ui-api-design/assets/3555826/cb021493-ada4-4ac2-8991-42a6d979207a"> <img width="1261" alt="Screenshot 2023-08-10 at 1 52 48 PM" src="https://github.com/Shopify/polaris/assets/3555826/6c2d9763-6b81-4808-9659-eb1db7b4bf1c"> This will give us the filtering behaviour in various areas and cases for free: - When actionGroups are rolledUp - In Bulk Actions - When actionGroups are not rolledUp, but still have more than 10 items This will also enable the rest of the admin to leverage this behaviour for free to give a consistent merchant experience. ## Open questions Using the TextField (or SearchField from filters) creates a circular dependency with the ActionList. What would be the right approach to have the search input with an icon without creating circular dependencies? ## Resources - Action Extensions tech doc - https://docs.google.com/document/d/1BEAHpkfeyUTaxW3B18LjojimDmqNLr1Fc2wfpMXzQ64/edit - Mockups for Action Extensions - https://www.figma.com/proto/afrUykUTB0n4GB4evE5F6R/%F0%9F%92%8EAdmin-UI-extension-patterns?node-id=398-111475&scaling=scale-down&page-id=295%3A118673&starting-point-node-id=398%3A111475&show-proto-sidebar=1 - Post in Admin UX (WxM) with an initial proposal - https://shopify.workplace.com/groups/1294395484626415/permalink/1321299791935984/ - Investigation of changes needed - Shopify/app-ui#36 (comment) --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
First draft of a code style guide to help with consistency --------- Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Sam Rose <[email protected]>
### WHY are these changes introduced? Fixes #10203 ### WHAT is this pull request doing? Changing Avatar background to transparent if there is an image passed in ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
This PR modifies translations in the project. It will append multiple commits and may add, modify, or delete translations. Feel free to merge anytime. ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch (`main`) and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack, inserting the PR number in the second argument: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=<this PR>`. The Spy command will recreate the translation commits based on the latest commit on `main` and open a new PR. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. @Shopify/polaris-eng Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
### WHY are these changes introduced? `react-rename-component-prop` migration was not working as expected when there were multiple props on a component <img width="552" alt="Screenshot 2023-08-24 at 10 12 10 AM" src="https://github.com/Shopify/polaris/assets/3474483/5ca5de71-f587-49cf-87ea-5fc73d298864"> ### WHAT is this pull request doing? - Adds more test cases - Fixes migration <img width="590" alt="Screenshot 2023-08-24 at 10 12 35 AM" src="https://github.com/Shopify/polaris/assets/3474483/8dc1ee41-1900-4383-81e0-7635b2d2fa0b"> --------- Co-authored-by: Aaron Casanova <[email protected]>
### WHY are these changes introduced? Fixes #10233 ### WHAT is this pull request doing? Necessary for Icon changes where we're changing `color` to `tone`, and also mapping `highlight` to `info`, `warning` to `caution`.
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes an issue where Desktop Safari has a font scale which is too small. <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We are wrapping the use of `font: -apple-system-body` within the mobile breakpoint to address the issue. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 **Desktop** 1. Visit [storybook](https://5d559397bae39100201eedc1-jcrahhpmju.chromatic.com/?path=/story/all-components-text--variants) in Desktop Safari 2. Open the Text Story 3. Ensure that the text size is normal 4. Double check with inspector and ensure `font:-apple-system-body` is not being applied **Mobile** 1. Visit [storybook](https://5d559397bae39100201eedc1-jcrahhpmju.chromatic.com/?path=/story/all-components-text--variants) in iOS Simulator 2. Open the Text Story 3. Within the inspector verify that `font: -apple-system-body` is being applied 4. Change the accessibility font size and verify text size updates correctly ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
### WHY are these changes introduced?
Fixes focus ring and text input styles on ActionList.SearchField with
beta flag enabled.
### WHAT is this pull request doing?
- Fixes focus ring styling
- FIxes text color on input
<details>
<summary>ActionList with search — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/e31a6b6b-6ca5-46f3-a240-ef1a76ae42cb"
alt="ActionList with search — before">
</details>
<details>
<summary>ActionList with search — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/c7e7c729-3d55-4ffb-937f-7df379a15d10"
alt="ActionList with search — after">
</details>
<!-- ℹ️ Delete the following for small / trivial changes -->
### How to 🎩
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
<!--
Give as much information as needed to experiment with the component
in the playground.
-->
<details>
<summary>Copy-paste this new story code in
<code>ActionList.stories.tsx</code> to test:</summary>
```jsx
export function WithSearch() {
const [active, setActive] = useState(true);
const toggleActive = useCallback(() => setActive((active) => !active), []);
const activator = (
<Button onClick={toggleActive} disclosure>
More actions
</Button>
);
return (
<div style={{height: '250px'}}>
<Popover
active={active}
activator={activator}
autofocusTarget="first-node"
onClose={toggleActive}
>
<ActionList
actionRole="menuitem"
sections={[
{
items: [
{content: 'Import file', icon: ImportMinor},
{content: 'Export file', icon: ExportMinor},
],
},
{
items: [
{content: 'Edit', icon: EditMinor},
{content: 'Delete', icon: DeleteMinor},
],
},
{
items: [
{
content: 'Blog posts',
helpText: 'Manage your blog articles',
},
{
content: 'Blogs',
helpText: 'Manage blogs published to your Online Store',
},
{
active: true,
content: 'Active blogs',
helpText: 'This is helpful text',
icon: ImportMinor,
suffix: <Icon source={TickSmallMinor} />,
},
{
disabled: true,
content: 'Disabled blogs',
helpText: 'This is also helpful text',
icon: ImportMinor,
suffix: <Icon source={TickSmallMinor} />,
},
],
},
]}
/>
</Popover>
</div>
);
}
```
</details>
### 🎩 checklist
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
### WHY are these changes introduced? Fixes #0000 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing?
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#10246](#10246) [`1947b4691`](1947b46) Thanks [@kyledurand](https://github.com/kyledurand)! - Added the ability to migrate prop values ### Patch Changes - [#10215](#10215) [`e4a6d47ab`](e4a6d47) Thanks [@aveline](https://github.com/aveline)! - Fixed a bug in the rename prop migration ## @shopify/[email protected] ### Minor Changes - [#9907](#9907) [`ef7ddb4ac`](ef7ddb4) Thanks [@MaxCloutier](https://github.com/MaxCloutier)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [#10288](#10288) [`cd1578230`](cd15782) Thanks [@ssetem](https://github.com/ssetem)! - Only apply apple dynamic text to mobile breakpoint - [#10292](#10292) [`72f55e32f`](72f55e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added check for string type before calling string method - [#10211](#10211) [`ac044b3c9`](ac044b3) Thanks [@peterlazzarino](https://github.com/peterlazzarino)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [#10287](#10287) [`9b14e231a`](9b14e23) Thanks [@laurkim](https://github.com/laurkim)! - Fixed focus ring and input text styles on `ActionList.SearchField` component ## [email protected] ### Patch Changes - Updated dependencies \[[`ef7ddb4ac`](ef7ddb4), [`cd1578230`](cd15782), [`72f55e32f`](72f55e3), [`ac044b3c9`](ac044b3), [`9b14e231a`](9b14e23)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes Shopify/web#102624 <!-- Context about the problem that’s being addressed. --> When a `TextField` `Spinner` is clicked on, the button is the document's active element (i.e. the button is focused). When hitting the enter key, if the `TextField` is in a form, the form should be submitted, but instead nothing happens. This differs from the default behaviour of an `<input type="number">` where the input is focused after clicking a spinner. See this codesandbox for a replication of the issue: https://codesandbox.io/s/cranky-rgb-ktnqml?file=/App.tsx Note that despite the button being focused previously, hitting enter had no effect, so this PR does not break or change existing functionality, only fixes broken behaviour. ### WHAT is this pull request doing? This PR changes the TextField component so the `input` is focused when the stepper is clicked. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) [Tophat on Storybook](https://5d559397bae39100201eedc1-wekmtcxvyp.chromatic.com/?path=/story/all-components-textfield--with-form-submit) 1. Click a stepper to increase the text field numerical value 2. Hit enter 3. The form should submit, and the text field should reset to '0'. Previously nothing happened. ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
## Context In MacOS's System Preferences > Appearance, choose these settings: <img width="475" alt="image" src="https://github.com/Shopify/polaris/assets/875708/2faa63e4-82ad-4fe1-8abe-7e0268c759f1"> Now browse the admin. As navigate between different pages, the body will sometimes overflow, sometimes not. This means scrollbars will come and go. For instance, while loading the data, the skeleton content will overflow and thus trigger scrollbars, but when minimal data comes in, the scrollbars might go away. This cases the UI to constantly jump ~15px left and right as the scrollbars come and go. ## This fix We thought _[a lot](https://docs.google.com/document/d/1AW7AFldJc6RZT4sHR303bqWMqLf0-CDXExEVf6hFg1w/edit#heading=h.e2bgx61b1bn2)_ about how we can improve the scrollbar behaviour. This PR completely circumvents the scrollbar logic by changing the layout constraints of Polaris core elements. It makes sure that, when a scrollbar is set to "always on", the content stays clear of the area where the scrollbar may appear. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Tested on device types, browsers and operating systems. <img width="1143" alt="Screenshot 2023-07-20 at 4 30 42 PM" src="https://github.com/Shopify/polaris/assets/875708/40f29f11-60a1-4b03-a7e2-d5c37524e353"> <img width="1143" alt="Screenshot 2023-07-20 at 4 28 12 PM" src="https://github.com/Shopify/polaris/assets/875708/1f55d2ea-7963-46c3-bc72-719e9f26d1f6"> <img width="1208" alt="Screenshot 2023-07-20 at 4 32 38 PM" src="https://github.com/Shopify/polaris/assets/875708/3407960f-5be6-4192-b92c-cff56975a1b5">
Adds filtering support for non-string content for ActionList items. --------- Co-authored-by: Kyle Durand <[email protected]>
Updates social media icons by removing them from their containers so
they are more identifiable. Also adds an icon for Twitch.
<!--
☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
- Start with a verb, for example: Add, Delete, Improve, Fix…
- Give as much context as necessary and as little as possible
- Prefix it with [WIP] while it’s a work in progress
-->
### WHY are these changes introduced?
We received feedback that the current icons were hard to distinguish
when next to each other.
<!--
Context about the problem that’s being addressed.
-->
### WHAT is this pull request doing?
<!--
Summary of the changes committed.
Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.
If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:
<details>
<summary>Summary of your gif(s)</summary>
<img src="..." alt="Description of what the gif shows">
</details>
-->
<!-- ℹ️ Delete the following for small / trivial changes -->
### How to 🎩
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
<!--
Give as much information as needed to experiment with the component
in the playground.
-->
<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>
```jsx
import React from 'react';
import {Page} from '../src';
export function Playground() {
return (
<Page title="Playground">
{/* Add the code you want to test in here */}
</Page>
);
}
```
</details>
### 🎩 checklist
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
github-actions
bot
added
the
cla-needed
laurkim
force-pushed
the
lo/update-next
branch
from
673b8f0 to
7930830
Compare
The child SearchField component was replaced with the existing TextField component in the `next` branch.
laurkim
force-pushed
the
lo/update-next
branch
from
7930830 to
87181fe
Compare
laurkim
removed
the
cla-needed
laurkim
commented
Sep 8, 2023
Comment on lines
24
to
30
| --pc-avatar-extra-small-size: 20px; | ||
| --pc-avatar-small-size: 24px; | ||
| --pc-avatar-medium-size: 28px; | ||
| --pc-avatar-large-size: 32px; | ||
| // stylelint-enable | ||
| background: var(--p-color-avatar-background-experimental); | ||
| color: var(--p-color-avatar-color-experimental); |
There was a problem hiding this comment.
These changes are already in the next branch from a previous pr to consolidate se23 logic.
github-actions
bot
added
the
cla-needed
laurkim
requested review from
mrcthms,
MaxCloutier,
kyledurand and
chloerice
|
Seeing a little layout shift when going between modes on mobile screens, the correct padding is when you're in the mode where you can see the Save as and Cancel buttons Screen.Recording.2023-09-08.at.17.17.19.mov |
Thanks for catching @mrcthms, just pushed up a commit to fix the padding on small screens 👍 08-23-4fld4-id1fe.mp4 |
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
Updates `next` branch with latest changes from `main`. - Resolves conflicts - Updates renamed components or breaking prop changes ([commit](fb5bc9b)) - Updates any new se23 styles or logic ([commit](e6784cd)) > 🚨 Please verify that changes in the last linked commit above look as expected in [storybook](https://5d559397bae39100201eedc1-autktgiyhr.chromatic.com/?path=/story/playground--details-page). --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jess Telford <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Joel Warrington <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Matt Lavoie <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Ash <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxime Cloutier <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Peter Lazzarino <[email protected]> Co-authored-by: James Highfield <[email protected]> Co-authored-by: Marten Bjork <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: zak warsame <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Laura Griffee <[email protected]>
Merged
sam-b-rose
pushed a commit
that referenced
this pull request
Sep 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @shopify/[email protected] ### Major Changes - [#10122](#10122) [`43b42aefed`](43b42ae) Thanks [@aveline](https://github.com/aveline)! - Removed `shape` prop on `Avatar` component - [#10270](#10270) [`b9bcaef41`](b9bcaef) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `spacing` prop to `gap` on `List` and `DescriptionList` - [#9997](#9997) [`b59fc9e27`](b59fc9e) Thanks [@yurm04](https://github.com/yurm04)! - [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant`. Replaced `spacing` prop with `gap` - [#10100](#10100) [`4c7b2d4858`](4c7b2d4) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated `borderRadius` props to match web spec - [#10051](#10051) [`69edd97ceb`](69edd97) Thanks [@aveline](https://github.com/aveline)! - Renamed `color` prop to `tone` for `ProgressBar` component - [#10182](#10182) [`e814c0ee1a`](e814c0e) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed connectedDislosure prop on button - [#10283](#10283) [`42ee9f407`](42ee9f4) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Renamed `size` prop values for the Avatar component. See the following table for the new prop mappings. | Before | After | | ------------------------- | ----------- | | `size="extraSmall"` | `size="xs"` | | `size="small"` | `size="sm"` | | `size="medium"` | `size="md"` | | `size="large"` | `size="lg"` | | `size="xl-experimental"` | `size="xl"` | | `size="2xl-experimental"` | `size="xl"` | - [#10232](#10232) [`eb2c2035c`](eb2c203) Thanks [@laurkim](https://github.com/laurkim)! - Removed `divider` prop from `Page` component - [#10271](#10271) [`1125087b5`](1125087) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed deprecated additionalNavigation prop on Page Header - [#10164](#10164) [`af9f264b9a`](af9f264) Thanks [@aveline](https://github.com/aveline)! - Renamed `destructive` prop to `tone` for `Button` component - [#10261](#10261) [`abeef7ad0`](abeef7a) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `small`, `large`, and `fullScreen` props with `size` prop - [#10206](#10206) [`dad09bde9`](dad09bd) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `status` prop on `Banner` to `tone` - [#10220](#10220) [`2b0cdb2fbf`](2b0cdb2) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `color` prop on `Icon` to `tone` - [#10036](#10036) [`359614cf83`](359614c) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `borderless` prop with `variant` on TextField Migration: `npx @shopify/polaris-migrator react-rename-component-prop <path> --componentName="TextField" --from="borderless" --to="variant" --newValue="borderless"` - [#10635](#10635) [`340e36e7d`](340e36e) Thanks [@laurkim](https://github.com/laurkim)! - Removed `polarisSummerEditions2023` feature flag from AppProvider context - [#10090](#10090) [`4caed28a77`](4caed28) Thanks [@aveline](https://github.com/aveline)! - Consolidated boolean `Button` props into `variant` prop - [#10041](#10041) [`8f927f7622`](8f927f7) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced boolean props: `secondary`, `fullWidth`, `oneHalf`, `oneThird` on Layout.Section with `variant` - [#10266](#10266) [`22a51eae2`](22a51ea) Thanks [@kyledurand](https://github.com/kyledurand)! - Renamed `color` prop on Text to `tone` - [#9993](#9993) [`66f5c8df3e`](66f5c8d) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Removed Summer Editions experimental styles and code for the following components: `AppProvider`, `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`, `Autocomplete`, `Badge`, `Banner`, `Breadcrumbs`, `BulkActions`, `Button`, `ButtonGroup`, `CalloutCard`, `Card`, `CheckableButton`, `Checkbox`, `Choice`, `Connected`, `DataTable`, `DatePicker`, `DropZone`, `EmptyState`, `Filters`, `FormLayout`, `Frame`, `FullscreenBar`, `IndexFilters`, `IndexTable`, `InlineError`, `KeyboardKey`, `Labelled`, `Layout`, `LegacyCard`, `LegacyFilters`, `LegacyTabs`, `Link`, `List`, `Listbox`, `MediaCard`, `Modal`, `Navigation`, `OptionList`, `Page`, `PageActions`, `Pagination`, `Popover`, `ProgressBar`, `RadioButton`, `ResourceItem`, `ResourceList`, `Select`, `SettingAction`, `ShadowBevel`, `SkeletonPage`, `SkeletonThumbnail`, `Spinner`, `Tabs`, `Tag`, `Text`, `TextField`, `Thumbnail`, `TooltipOverlay`, `TopBar`, and `VideoThumbnail` - [#10232](#10232) [`eb2c2035c`](eb2c203) Thanks [@laurkim](https://github.com/laurkim)! - Removed `optionRole` prop from `OptionList` component ### Minor Changes - [#10238](#10238) [`b17d23d69`](b17d23d) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [#10228](#10228) [`e18ca907e`](e18ca90) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `Filters` Remove unused disabled states in `FilterPill` - [#10268](#10268) [`dbe3d9ece`](dbe3d9e) Thanks [@laurkim](https://github.com/laurkim)! - Fixed broken focus ring styles on `ResourceItem` component - [#10238](#10238) [`b17d23d69`](b17d23d) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [#10230](#10230) [`a573e55d0`](a573e55) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `IndexFilter` remove custom `FilterButton` in favor of directly invoking the Polaris `Button` component. - Updated dependencies \[[`86d4040c0`](86d4040)]: - @shopify/[email protected] ## @shopify/[email protected] ### Minor Changes - [#10382](#10382) [`86d4040c0`](86d4040) Thanks [@laurkim](https://github.com/laurkim)! - Renamed `ThemeVariant` to `Theme` and exposed `Theme` type ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`86d4040c0`](86d4040)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Updates `next` branch with latest changes from `main`. - Resolves conflicts - Updates renamed components or breaking prop changes ([commit](Shopify@45edcd6)) - Updates any new se23 styles or logic ([commit](Shopify@fa47225)) > 🚨 Please verify that changes in the last linked commit above look as expected in [storybook](https://5d559397bae39100201eedc1-autktgiyhr.chromatic.com/?path=/story/playground--details-page). --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jess Telford <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Joel Warrington <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Rose <[email protected]> Co-authored-by: Matt Lavoie <[email protected]> Co-authored-by: aveline <[email protected]> Co-authored-by: Aaron Casanova <[email protected]> Co-authored-by: Ash <[email protected]> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxime Cloutier <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Peter Lazzarino <[email protected]> Co-authored-by: James Highfield <[email protected]> Co-authored-by: Marten Bjork <[email protected]> Co-authored-by: Joe Thomas <[email protected]> Co-authored-by: zak warsame <[email protected]> Co-authored-by: Chloe Rice <[email protected]> Co-authored-by: Marc Thomas <[email protected]> Co-authored-by: Laura Griffee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
nextbranch with latest changes frommain.