[ButtonGroup] Update variant plain prop name #10222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
approved these changes
Aug 24, 2023
|
@laurkim caught it with her super thorough tophatting on my LegacyCard PR!! :dreamteam: |
sam-b-rose
added a commit
that referenced
this pull request
Aug 25, 2023
* next: (87 commits) [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant` (#9997) [LegacyTabs] Consolidate se23 styles and logic (#10231) [v12] Update changesets (#10232) [LegacyFilters] Consolidate se23 styles and logic (#10217) [Banner] Change status prop to tone (#10206) Replace icon highlight color in box stories (#10226) [TopBar] Consolidate se23 styles and logic (#10221) [Filters] consolidate se23 logic and styles (#10178) [Icon] Update props (#10220) [ButtonGroup] Update variant plain prop name (#10222) [Button] Remove connectedDisclosure (#10182) [LegacyCard] Consolidate se23 styles and logic (#10207) [Navigation] Consolidate se23 logic and styles (#10213) [Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196) [OptionList] consolidate se23 styles and logic (#10177) [Page] Consolidate se23 styles and logic (#10187) [DataTable] Consolidate conditional logic (#10169) [Thumbnail] Consolidate conditional logic (#10171) [ResourceItem] Consolidate conditional logic (#10172) [FullscreenBar] Consolidate conditional logic (#10173) ...
sam-b-rose
added a commit
that referenced
this pull request
Aug 25, 2023
* next: (87 commits) [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant` (#9997) [LegacyTabs] Consolidate se23 styles and logic (#10231) [v12] Update changesets (#10232) [LegacyFilters] Consolidate se23 styles and logic (#10217) [Banner] Change status prop to tone (#10206) Replace icon highlight color in box stories (#10226) [TopBar] Consolidate se23 styles and logic (#10221) [Filters] consolidate se23 logic and styles (#10178) [Icon] Update props (#10220) [ButtonGroup] Update variant plain prop name (#10222) [Button] Remove connectedDisclosure (#10182) [LegacyCard] Consolidate se23 styles and logic (#10207) [Navigation] Consolidate se23 logic and styles (#10213) [Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196) [OptionList] consolidate se23 styles and logic (#10177) [Page] Consolidate se23 styles and logic (#10187) [DataTable] Consolidate conditional logic (#10169) [Thumbnail] Consolidate conditional logic (#10171) [ResourceItem] Consolidate conditional logic (#10172) [FullscreenBar] Consolidate conditional logic (#10173) ...
sophschneider
added a commit
that referenced
this pull request
Sep 19, 2023
### WHAT is this pull request doing? Update `ButtonGroup` variant styles to match the changes from #10090 ### How to 🎩 Check that this story is getting the plain button group item variant |Next branch|This PR|Production| |-|-|-| |<img width="321" alt="Screenshot 2023-08-24 at 2 36 27 PM" src="https://github.com/Shopify/polaris/assets/20652326/54bff50b-f4b1-4540-a891-7f3c4a7afaf7">|<img width="306" alt="Screenshot 2023-08-24 at 2 37 27 PM" src="https://github.com/Shopify/polaris/assets/20652326/3dd5578e-51ad-4469-82fe-61db3440b936">|<img width="303" alt="Screenshot 2023-08-24 at 2 37 12 PM" src="https://github.com/Shopify/polaris/assets/20652326/7141b6a8-9589-4746-a7d7-eb9229a6c61d">|
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHAT is this pull request doing? Update `ButtonGroup` variant styles to match the changes from Shopify#10090 ### How to 🎩 Check that this story is getting the plain button group item variant |Next branch|This PR|Production| |-|-|-| |<img width="321" alt="Screenshot 2023-08-24 at 2 36 27 PM" src="https://github.com/Shopify/polaris/assets/20652326/54bff50b-f4b1-4540-a891-7f3c4a7afaf7">|<img width="306" alt="Screenshot 2023-08-24 at 2 37 27 PM" src="https://github.com/Shopify/polaris/assets/20652326/3dd5578e-51ad-4469-82fe-61db3440b936">|<img width="303" alt="Screenshot 2023-08-24 at 2 37 12 PM" src="https://github.com/Shopify/polaris/assets/20652326/7141b6a8-9589-4746-a7d7-eb9229a6c61d">|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Update
ButtonGroupvariant styles to match the changes from #10090How to 🎩
Check that this story is getting the plain button group item variant