Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User testing sessions 4 / 5 notes #7592

Closed
5 of 8 tasks
kyledurand opened this issue Nov 1, 2022 · 1 comment · Fixed by #7593
Closed
5 of 8 tasks

User testing sessions 4 / 5 notes #7592

kyledurand opened this issue Nov 1, 2022 · 1 comment · Fixed by #7593

Comments

@kyledurand
Copy link
Member

kyledurand commented Nov 1, 2022

kyledurand added a commit that referenced this issue Nov 1, 2022
@kyledurand kyledurand reopened this Nov 1, 2022
kyledurand added a commit that referenced this issue Nov 3, 2022
Part of #7592

Reasons why we don't want to wrap children in div
- Unexpected layouts. Passing in an inline element gets renders in a
block
- Performance. Looping over ever child element to wrap in an extra div
can add up. This is also less performant on the client as it adds to the
DOM
- Argo and other consumers have to do funky things to match this
functionality cc @olavoasantos

Expected vs unexpected layout:

![image](https://user-images.githubusercontent.com/6844391/199729692-098b5bc0-7617-4561-95e5-556a711883a8.png)

Co-authored-by: Lo Kim <[email protected]>
kyledurand added a commit that referenced this issue Nov 3, 2022
…#7633)

Part of #7592

> Add more granular control within Inline i.e. justify-content:
space-between

Changed `alignY` prop name to `blockAlign` to be multiple writing mode
friendly.
kyledurand added a commit that referenced this issue Nov 4, 2022
Bleed should do something by default. This offsets the default
horizontal padding from AlphaCard which I think will be the most common
use case

Part of #7592
@kyledurand
Copy link
Member Author

Closing this now all other items are being address or already have been

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant