[Typography foundations] Replace usage of deprecated type components #6588
Assignees
Comments
laurkim
added a commit
that referenced
this issue
Nov 3, 2022
### WHY are these changes introduced? Resolves #6588, resolves #7192, resolves #7584, resolves #7047, resolves #7197, resolves #7048, resolves #7199, resolves #7206, resolves #7205, resolves #7598, resolves #7583. ### WHAT is this pull request doing? Replaces the old typography components with the new `Text` component. These changes where created using the `replace-text-component` migration: ```sh polaris-migrator replace-text-component "./polaris-react/src/**/*.tsx" --relative ``` Additionally, manual updates for the following text mixins have been updated to either use the `Text` component or the token inside the classes directly: - **text-style-body** - **text-style-heading** - **text-style-subheading** - **text-style-caption** - **text-style-button** - **text-style-button-large** - **text-emphasis-subdued** - **text-emphasis-strong** - **nav-item-text-attributes** Co-authored-by: Lo Kim <[email protected]> Co-authored-by: Kyle Durand <[email protected]> Co-authored-by: Alex Page <[email protected]>
|
Once the PR to update Text in stories is merged, this issue can be closed. |
laurkim
added a commit
that referenced
this issue
Nov 3, 2022
### WHY are these changes introduced? Resolves #6588. ### WHAT is this pull request doing? Runs the `replace-text-component` migration without the relative flag to update and replace instances where text components are imported from `@shopify/polaris` in the `polaris-react` directory. Related to the [PR](#7530) that replaces relative imports. Co-authored-by: Sam Rose <[email protected]>
5 tasks
laurkim
added a commit
that referenced
this issue
Nov 3, 2022
### WHY are these changes introduced? Resolves #6588. ### WHAT is this pull request doing? Replaces usage of legacy typography components in the style guide to use the new `<Text />` component with the polaris migrator: ```sh polaris-migrator replace-text-component "./polaris.shopify.com/pages/**/*.tsx" ``` <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the existing type components are deprecated, replace places they're used in polaris-react with the new Text component.
The text was updated successfully, but these errors were encountered: