Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation example input field is not working as expected #2

Closed
paulxuca opened this issue Apr 20, 2017 · 6 comments
Closed

Documentation example input field is not working as expected #2

paulxuca opened this issue Apr 20, 2017 · 6 comments

Comments

@paulxuca
Copy link

Issue summary

Example input field does not preserve input value

Expected behavior

If I type in "Dog", it should say Dog, not g (since only last input is preserved.)

Actual behavior

I type in "Dog", and only g is displayed.

Steps to Reproduce the Problem

  1. Go to: https://polaris.shopify.com/components/titles-and-text/display-text#examples (Or any exmple with an input field)
  2. Type in "Dog"
  3. Observe only g is displayed.

Specifications

  • Polaris version: 1.0.1
@reggi
Copy link

reggi commented Apr 20, 2017

@paulxuca It seems that the input field to alter the children doesn't work correctly (only puts in one letter at a time), but if you click into the component itself it does work.

xx

@reggi
Copy link

reggi commented Apr 20, 2017

This works for the heading component though.

working

@lemonmade
Copy link
Member

Thanks for the issue, @paulxuca. We actually have a PR open to fix this on a few pages (it affects any component that has a pascal case name with more than one capital letter — I'll leave it to the reader to guess how we managed to create a bug like that 😄). We'll close this issue once we've fixed it up.

@paulxuca
Copy link
Author

Thanks for both the replication examples above and your quick response! Looking forward to changes in this project! :D

@sarcos
Copy link

sarcos commented Apr 22, 2017

@reggi may I ask how do you create those .gif ? thx

@reggi
Copy link

reggi commented Apr 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants