prevent tabbing to hidden submit

Shopify · Nov 20, 2019 · 53206c7 · 53206c7
1 parent 35d61d2
commit 53206c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -7,6 +7,7 @@
 - Added `external` prop to `ResourceList` ([#2408](https://github.com/Shopify/polaris-react/pull/2408))
 - Added `onMouseEnter` and `onTouchStart` props to `Button` ([#2409](https://github.com/Shopify/polaris-react/pull/2409))
 - Added `ariaHaspopup` prop to `Popover` ([#2248](https://github.com/Shopify/polaris-react/pull/2248))
+- Fixed an accessibility issue where the `Form` implicit submit was still accessible via keyboard ([#2447](https://github.com/Shopify/polaris-react/pull/2447))
 
 ### Bug fixes
 

diff --git a/src/components/Form/Form.tsx b/src/components/Form/Form.tsx
@@ -71,7 +71,7 @@ export function Form({
 
   const submitMarkup = implicitSubmit ? (
     <VisuallyHidden>
-      <button type="submit" aria-hidden="true">
+      <button type="submit" aria-hidden="true" tabIndex={-1}>
         {i18n.translate('Polaris.Common.submit')}
       </button>
     </VisuallyHidden>