Skip to content

Commit

Permalink
PR Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
BPScott committed Jan 3, 2019
1 parent 3e0b77d commit 3dde509
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions .storybook/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ addDecorator(
mainTextColor: '#212B36',
highlightColor: '#202e78',
dimmedTextColor: '#637381',
mainTextSize: '16',
successColor: '#108043',
failColor: '#bf0711',
warnColor: '#f49342',
// TODO more pretty brand colors?
// SEE https://github.com/storybooks/storybook/blob/next/lib/components/src/theme.js
},
Expand Down
4 changes: 2 additions & 2 deletions .storybook/polaris-readme-loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function parseCodeExamples(data) {
function generateExamples(matter) {
if (matter.data.platforms && !matter.data.platforms.includes('web')) {
console.log(
chalk`ℹ️ {grey [${
chalk`ℹ️ {grey [${
matter.data.name
}] Component examples are ignored (platforms: ${matter.data.platforms.join(
',',
Expand All @@ -121,7 +121,7 @@ function generateExamples(matter) {

if (matter.data.hidePlayground) {
console.log(
chalk`ℹ️ {grey [${
chalk`ℹ️ {grey [${
matter.data.name
}] Component examples are ignored (hidePlayground: true)}`,
);
Expand Down
4 changes: 4 additions & 0 deletions .storybook/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ module.exports = (baseConfig, env, config) => {
baseConfig.stats = stats;
baseConfig.devServer = {stats};

// Shrink ray only strips hashes when comparing filenames with this format.
// Without this there will be lots of "add 1 file and removed 1 file" notices.
baseConfig.output.filename = '[name]-[hash].js';

const cacheDir = path.resolve(__dirname, '../build/storybook/cache');

const extraRules = [
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ We have created example applications to document some of the ways you could incl

## Development

We use Storybook to create a simple, hot-reloading playground for development on these components. You can edit the `playground/Playground.tsx` file to import the components you are working on, and run `yarn dev` in order to start the development server. Please do not commit your work on the playground so that it is pristine for other developers to work on.
We use Storybook to create a simple, hot-reloading playground for development on these components. You can edit the `playground/Playground.tsx` file to import the components you are working on, and run `yarn dev` in order to start the development server. Please do not commit your work on the playground so that it remains pristine for other developers to work on.

### Testing on mobile or a virtual machine

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"heroku-postbuild": "yarn run copy-polaris-tokens",
"readme-update-version": "babel-node ./scripts/readme-update-version",
"version": "yarn run readme-update-version",
"storybook": "start-storybook -p 6006",
"storybook": "start-storybook -p 6006 --quiet",
"storybook:build": "yarn run copy-polaris-tokens && build-storybook -o build/storybook/static"
},
"stylelint": {
Expand Down

0 comments on commit 3dde509

Please sign in to comment.