Use api access from shopify api #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezaansyed
force-pushed
the
use-api-access-from-shopify-api
branch
2 times, most recently
from
a26e06b to
1517cf4
Compare
rezaansyed
force-pushed
the
use-api-access-from-shopify-api
branch
from
1517cf4 to
97ea8b0
Compare
rezaansyed
requested review from
ragalie,
tanema,
greatestape,
alexaitken,
NabeelAhsen and
theundeadmonk
paulomarg
reviewed
Jan 28, 2021
| @@ -1,2 +1,3 @@ | |||
| require 'omniauth/shopify/version' | |||
| require 'omniauth/strategies/shopify' | |||
| require 'shopify_api' | |||
There was a problem hiding this comment.
This is sort of creating a circular dependency: shopify_app => omniauth-shopify-oauth2 => shopify_api <= shopify_app. Is that a problem? I'm guessing no but thought I'd check.
There was a problem hiding this comment.
Yeah, I'm not sure of the consequences, but this strikes me as something to be cautious about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Shopify/shopify-api-ruby#829
What does this PR solve?
There are common operations that are used for scopes on OmniAuth and apps consuming the gem. Such operations include serializing, deserializing and normalizing scopes. This PR uses the
ApiAccessclass fromshopify_apithat will be used to perform such operations.