Sidekiq callback instead of internals for graceful shutdown #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
force-pushed
the
sidekiq-callback
branch
from
8b9f40a to
aefe67b
Compare
Mangara
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Great call! I see that Sidekiq 3.0 was released in 2014, so dropping support for older versions is not a concern.
Happens at the same time as the old code: https://github.com/sidekiq/sidekiq/blob/73c150d0430a8394cadb5cd49218895b113613a0/lib/sidekiq/launcher.rb#L47-L54 but this is less brittle. Sidekiq::CLI is only defined when Sidekiq runs as a standalone process. Since 7.0 it can also run embedded in the web server process, and using this hook allows Iteration to be compatible with mode of operation. The same events are fired here: https://github.com/sidekiq/sidekiq/blob/73c150d0430a8394cadb5cd49218895b113613a0/lib/sidekiq/embedded.rb#L24-L30
bdewater
force-pushed
the
sidekiq-callback
branch
from
aefe67b to
2776ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens at the same time as the old code: https://github.com/sidekiq/sidekiq/blob/73c150d0430a8394cadb5cd49218895b113613a0/lib/sidekiq/launcher.rb#L47-L54 but this is less brittle. The docs even give a Iteration-like example in Sidekiq Pro to stop on the quiet signal.
Sidekiq::CLIis only defined when Sidekiq runs as a standalone process. Since 7.0 it can also run embedded in the web server process asSidekiq::Embedded, and using this hook allows Iteration to be compatible with mode of operation. The same events are fired here: https://github.com/sidekiq/sidekiq/blob/73c150d0430a8394cadb5cd49218895b113613a0/lib/sidekiq/embedded.rb#L24-L30The callback itself exists since Sidekiq 3.0: sidekiq/sidekiq@3d117e6