Return nil from Iteration#perform
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
commented
Aug 18, 2023
sambostock
force-pushed
the
return-nil-from-perform
branch
from
14c6839 to
ae05f81
Compare
Mangara
approved these changes
Aug 18, 2023
`perform` should be treated as `void`, with consumers not coupling to its return value. Explicitly returning `nil` ensures the return value does not change if we happen to change the implementation.
sambostock
force-pushed
the
return-nil-from-perform
branch
from
ae05f81 to
0395d2f
Compare
Mangara
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performshould be treated asvoid, with consumers not coupling to its return value.Explicitly returning
nilensures the return value does not change if we happen to change the implementation.