This repository was archived by the owner on Apr 27, 2021. It is now read-only.
Add unit tests for sticky lua module #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmejia97
force-pushed
the
add-sticky-module-unit-tests
branch
2 times, most recently
from
c05f004 to
47c4376
Compare
ElvinEfendi
reviewed
Jul 11, 2018
|
|
||
| describe("balance()", function() | ||
| setup(function() | ||
| util.sha1_digest = function(msg) return msg, false end -- Don't hash for simplification |
There was a problem hiding this comment.
comment is not adding any value here imo
ElvinEfendi
reviewed
Jul 11, 2018
| } | ||
| end | ||
| local sticky_balancer_instance = sticky:new(test_backend) | ||
| local s = spy.on(sticky_balancer_instance.instance, "next") |
There was a problem hiding this comment.
Can we avoid this? This test should not know the implementation details of balance function. Why don't you assert on the return value of :balance?
There was a problem hiding this comment.
Good point, it currently feels a bit hacky. I like the approach you suggested 👍
ElvinEfendi
reviewed
Jul 11, 2018
| end | ||
| local sticky_balancer_instance = sticky:new(get_test_backend()) | ||
| assert.has_no.errors(function() sticky_balancer_instance:balance() end) | ||
| assert.spy(s).was_called() |
There was a problem hiding this comment.
Can you also assert on the parameters of cookie? i.e what key, value, path, domain it is setting.
ElvinEfendi
reviewed
Jul 11, 2018
| end) | ||
| end) | ||
|
|
||
| context("when client has a cookie set", function() |
There was a problem hiding this comment.
You are missing a crucial test here. We should make sure :balance returns the correct endpoint for given cookie value.
|
@ElvinEfendi Addressed your comments |
ElvinEfendi
reviewed
Jul 11, 2018
| local sticky_balancer_instance = sticky:new(test_backend) | ||
| local ip, port = sticky_balancer_instance:balance() | ||
| assert.equal(ip .. ":" .. port, test_backend_endpoint) | ||
| end) |
There was a problem hiding this comment.
This test isn't covering the logic properly:
> ingress (add-sticky-module-unit-tests)$ git diff
diff --git a/rootfs/etc/nginx/lua/balancer/sticky.lua b/rootfs/etc/nginx/lua/balancer/sticky.lua
index 8af93a98..348cb94b 100644
--- a/rootfs/etc/nginx/lua/balancer/sticky.lua
+++ b/rootfs/etc/nginx/lua/balancer/sticky.lua
@@ -70,7 +70,8 @@ local function sticky_endpoint_string(self)
set_cookie(self, key)
end
- return self.instance:find(key)
+ return key
+ --return self.instance:find(key)
end
function _M.balance(self)
> ingress (add-sticky-module-unit-tests)$ make lua-test
Makefile:160: warning: overriding commands for target `verify-all'
Makefile:156: warning: ignoring old commands for target `verify-all'
●●●●●●●●●●●●●●●●●●●●●
21 successes / 0 failures / 0 errors / 0 pending : 0.02952 seconds
hnrytrn
reviewed
Jul 16, 2018
|
|
||
| it("should return the correct endpoint for the client", function() | ||
| local cookie = require("resty.cookie") | ||
| local s = {} |
fmejia97
force-pushed
the
add-sticky-module-unit-tests
branch
from
06e6cf2 to
4bcc9e6
Compare
fmejia97
force-pushed
the
add-sticky-module-unit-tests
branch
from
4bcc9e6 to
15cad2a
Compare
|
@ElvinEfendi Updated the tests. Removed |
fmejia97
force-pushed
the
add-sticky-module-unit-tests
branch
from
6e77f19 to
d9bed56
Compare
fmejia97
force-pushed
the
add-sticky-module-unit-tests
branch
2 times, most recently
from
d411ccd to
5085291
Compare
fmejia97
force-pushed
the
add-sticky-module-unit-tests
branch
from
5085291 to
a570797
Compare
|
this was completed at kubernetes#2966 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds unit tests to
stickylua module. We need this because we don't have unit test coverage for this module.Issue: https://github.com/Shopify/edgescale/issues/435