This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
Fix buildupstream name to work with dynamically enabled session affinity #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrdaley
force-pushed
the
sticky-ups-name
branch
from
b936908 to
c064c04
Compare
zrdaley
changed the title
|
this looks good to me, please go fmt your code and regenerate bindata and make upsteam PR directly for this with the enough context |
|
this was merged to upstream master in kubernetes#2340 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dynamic configuration is enabled
ngx.var.proxy_upstream_nameis used to get the current backend (stored on the NGINX configuration) in the balancer lua module. This variabled is created inbuildUpstreamNamein /internal/ingress/controller/controller.go. However, backends stored in the NGINX configuration do not use the conventionsticky-<upstream-name>.This PR prevent
buildUpstreamNamefrom using the naming conventionsticky-<upstream-name>when dynamic configuration is enabled.