Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the license field in various package.json #922

Merged
merged 1 commit into from
May 23, 2023

Conversation

frehner
Copy link
Contributor

@frehner frehner commented May 22, 2023

Closes #893

@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it inappropriate to reference a file in the license field?

@frandiox
Copy link
Contributor

frandiox commented May 23, 2023

@blittle Certain tools and websites pick this field to show the license automatically so it doesn't work well for us 🤔

@frehner
Copy link
Contributor Author

frehner commented May 23, 2023

@blittle See this comment for an example of what this looks like in npm #893 (comment)

@frehner
Copy link
Contributor Author

frehner commented May 23, 2023

npm's official package.json docs also recommend using the identifier:

If you're using a common license such as BSD-2-Clause or MIT, add a current SPDX license identifier for the license you're using, like this:
...
If you are using a license that hasn't been assigned an SPDX identifier, or if you are using a custom license, use a string value like this one:

{
 "license" : "SEE LICENSE IN <filename>"
}

@frehner frehner merged commit e1caba9 into 2023-04 May 23, 2023
@frehner frehner deleted the fix-licenses-packagejson branch May 23, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up repo LICENSE situation
3 participants