Update ($lang).products.$productHandle.tsx #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, do you mind generating a changeset for this? |
|
@frehner updated on both PRs 🎉 |
frehner
approved these changes
Apr 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
this change fixes layout issues on mobile
before
after
WHAT is this pull request doing?
removes the w-screen as it was actually causing the ProductGallary to render outside of its container causing a scrollbar on mobile
HOW to test your changes?
Post-merge steps
Checklist
Notes
wasn't sure if this PR warrents a changeset, but if you think so, happy to create one :)