Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist folder to eslintignore to fix npx lint script #570

Conversation

DennisKraaijeveld
Copy link

@DennisKraaijeveld DennisKraaijeveld commented Feb 22, 2023

WHY are these changes introduced?

When running the lint script it caused a problem where the script would ran stuck and took forever to complete. This was caused by the worker and client folders inside the dist folder.

WHAT is this pull request doing?

I have added the dist folder to the .eslintignore file to solve this problem.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes

@DennisKraaijeveld
Copy link
Author

Signed the CLA. If someone can rerun that GH action for me that would be awesome! Thanks

@blittle
Copy link
Contributor

blittle commented Mar 13, 2023

Thank you for this contribution. It's resolved in another PR.

@blittle blittle closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants