fix template download check on windows #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the help @tchalabi! Sadly we are still working on getting a Windows license on our end, so your feedback really helps! |
|
I verified @tchalabi 's changes on my own machine.
|
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up on #520 and #499
@frandiox i am having the same issue and sadly your PR didn't solve it for me,
so i looked into the issue on my own and found this
after wrapping the check with
path.normalizei was able to execute the command without any issue.i made a PR in the hope to help others that have the same issue 🙂
if you need any additional info/help with testing debugging please feel free to ping me
best regards