Fix the creation of Hydrogen projects on Windows #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
blittle
approved these changes
Feb 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #476
The approach following approach to obtain the absolute path where the templates should be downloaded leads to Windows paths (i.e.
C://) prefixed with a forward slash:I've adjusted the implementation to use
fileURLToPathand I've taken the opportunity to use the asynchronous IO APIs instead. Going forward, I recommend using the modules provided by@shopify/cli-kitwhen working with the file-system and paths. Node's standard library is known for its inconsistencies across OSs and hence why libraries like pathe, which@shopify/cli-kituses internally. I'd also recommend using the asynchronous version of the APIs. It leads to more scatteredawaitsbut allows to execute the logic concurrently with other promises.