Send Hydrogen version in requests to Storefront API #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this in H1 so I'm adding the same behavior here.
However, a somewhat related problem is that this
LIB_VERSION
is updated after the package is built. Therefore, I think a newly released package always contains the version from the previous release.It's been like this since H1, where we modified the "source" instead of the "dist".
Any ideas on how to fix that? We could modify the generated bundle but it doesn't feel right. Could we run
changeset version
beforenpm run build
? Or would that problematic?