Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the SEO logging added in #400 to a lazily imported component. This allows for code-splitting and for it to be auto-disabled in production and auto-enabled in development (though this lives in user-land so it is easy to change this functionality if, for example, users wanted to enable via a query string).
For tophatting, you can run the demo-store via
dev
, you should see the logs. Then run the demo-store viapreview
and you should not see the logs. You can also filter the network requests to see the additional JS request for the logger code. See screenshot below:cc @gfscott