Remove RSK as a direct dependency in the demo stores #398
Conversation
Instead it now is a direct dependency of `@Shopify/hydrogen` with select functionality re-exported
|
We detected some changes in |
| "./package.json": "./package.json" | ||
| }, | ||
| "typesVersions": { | ||
| "*": { |
| ModelViewer, | ||
| parseMetafield, | ||
| ShopPayButton, | ||
| } from '@shopify/storefront-kit-react'; |
There was a problem hiding this comment.
Wonder if there's a sustainable way of making sure you have everything you need re-exported; maybe keeping it alphabetical so you can compare more easily or something?
Not blocking by any means, but just thinking about how to make it easier in the future. Because I suspect that there may be some things already missing?
There was a problem hiding this comment.
Yeah, there probably are some missing items. I'll go check, and also make it alphabetical. Though we don't want any of the carts stuff.
| @@ -1,5 +1,5 @@ | |||
| // TODO more this whole file to a storefront-react package | |||
| import type {Maybe} from '@shopify/storefront-kit-react/storefront-api-types'; | |||
| import type {Maybe} from '@shopify/hydrogen/storefront-api-types'; | |||
There was a problem hiding this comment.
You might need to revert this change. I think you are reaching for an export that doesn't exist when this package is built. Not a huge deal either way since this is all getting re-jigged.
There was a problem hiding this comment.
Ah, good catch. Everything from the hydrogen package itself should be importing from storefront-kit. This was one was an accident.
Instead it now is a direct dependency of
@shopify/hydrogenwith select functionality re-exported