-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve local development (v3) #275
Conversation
We detected some changes in |
👋 It seems that this PR is adding a GitHub Action workflow that looks a lot like a CI step. CI should generally be handled with Shopify Build pipelines, and GitHub Actions should be used for GitHub automation and package publishing. If this workflow change is not introducing a CI step, then feel free to ignore this comment. For more details and explanation, click to expand...GitHub Actions are generally intended for GitHub, Project or Repository-related automation, or for public package and library publishing. You can learn more about the supported use cases in our GitHub Actions documentation. If your Action is a CI step, please migrate to shopify-build instead. If you have any questions about how to setup a Note that this message is based on a simple regex detection, and may not always be accurate. If your action is not a CI step, and is already running on If your repository is intended to become Public later, please use |
Amazing fran 🎩 was 💯 |
Since it's been top-hatted already and this PR is mostly fixing local dev/build, I'm going to merge this before we get more conflicts. Feel free to leave comments and I will address them in another PR 👍 |
Few magic things happening here:
hydrogen-remix/build
since we only use the production one.tsup
instead oftsc
to build the CLI, which allows us to add the CLI to Turbo watched packages without a weird flickering in the terminal.npm run build
times by skipping demo-store build when not needed, and some other generated stuff..hydrogen
in JS projects.Limitation: files don't include JSX (they are compiled). I'm trying to figure out why the(I've figured it out)jsx: "preserve"
option in TS doesn't work.<root>/public/*
) are now watched and live-reloaded.hydrogen-remix/src/templates
.hydrogen-remix/src/templates
in local development (requested by @juanpprieto ).remix.config.js
is modified, so that changing our own options likeincludeCart: false
inhydrogenRoutes
reload stuff. cc @blittleFor 🎩 :
npm run clean-all && npm i
. Then,npm run dev
at the top and check that the app is working.remix.config.js
to add a console.log. It should reload and print it.packages/hydrogen-remix/src/templates
. It should reload properly.demo-store/tsconfig.json
todemo-store/jsconfig.json
and restartnpm run dev
. It should copy.jsx
files todemo-store/.hydrogen
instead of.tsx
.