Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API products #265

Closed
wants to merge 3 commits into from
Closed

Remove API products #265

wants to merge 3 commits into from

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Nov 30, 2022 •
edited
Loading

Instead of having both /products and /api/products, just have /products

@github-actions github-actions bot had a problem deploying to preview November 30, 2022 20:51 Failure
@github-actions github-actions bot had a problem deploying to preview November 30, 2022 20:53 Failure
juanpprieto
juanpprieto approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it makes sense to move /api/countries out into a /routes/countries or /resource/countries ?

@blittle blittle force-pushed the bl-remove-api-products branch from 17ba2df to f5d1c77 Compare November 30, 2022 21:26
@github-actions github-actions bot had a problem deploying to preview November 30, 2022 21:28 Failure
@blittle
Copy link
Contributor Author

blittle commented Nov 30, 2022

@juanpprieto just moved /api/countries to /countries

@blittle blittle closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpprieto juanpprieto juanpprieto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blittle @juanpprieto