Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore cli-kit dependency #2629

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Restore cli-kit dependency #2629

merged 1 commit into from
Oct 30, 2024

Conversation

rbshop
Copy link
Contributor

@rbshop rbshop commented Oct 30, 2024

WHY are these changes introduced?

Shopify/cli#4770 is currently blocked because of a failure when trying to resolve @shopify/cli-kit on CI. I believe this is caused by a switch from cli-kit to cli in #2617

WHAT is this pull request doing?

This PR is restoring the @shopify/cli-kit dependency

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Oct 30, 2024

Oxygen deployed a preview of your rb-restore-cli-kit-dependency branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment October 30, 202411:34 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment October 30, 202411:34 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment October 30, 202411:34 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment October 30, 202411:34 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment October 30, 202411:34 AM

Learn more about Hydrogen's GitHub integration.

@rbshop rbshop merged commit 3c002f7 into main Oct 30, 2024
12 checks passed
@rbshop rbshop deleted the rb-restore-cli-kit-dependency branch October 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant