Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --worker CLI flag #2603

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Remove deprecated --worker CLI flag #2603

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18e3f6c
Remove deprecated --worker cli flag
rbshop Oct 14, 2024
b881013
Remove deprecated --env-branch cli flag
rbshop Oct 14, 2024
d8b1cf1
Added a changeset
rbshop Oct 14, 2024
fc4331a
update to minor bump
wizardlyhel Oct 23, 2024
56bae64
Revert removal of --env-branch cli flag
rbshop Oct 24, 2024
d212fce
Remove preview metadata description
wizardlyhel Oct 24, 2024
32d9f39
format
wizardlyhel Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-paws-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/cli-hydrogen': minor
---

Remove deprecated --worker cli flag
12 changes: 1 addition & 11 deletions packages/cli/oclif.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@
"type": "option"
},
"preview": {
"description": "Deploys to the Preview environment. Overrides --env-branch and Git metadata.",
"description": "Deploys to the Preview environment.",
"name": "preview",
"required": false,
"allowNo": false,
Expand Down Expand Up @@ -669,11 +669,6 @@
"allowNo": false,
"type": "boolean"
},
"worker": {
"hidden": true,
"name": "worker",
"type": "boolean"
},
"legacy-runtime": {
"description": "[Classic Remix Compiler] Runs the app in a Node.js sandbox instead of an Oxygen worker.",
"env": "SHOPIFY_HYDROGEN_FLAG_LEGACY_RUNTIME",
Expand Down Expand Up @@ -1323,11 +1318,6 @@
"multiple": false,
"type": "option"
},
"worker": {
"hidden": true,
"name": "worker",
"type": "boolean"
},
"legacy-runtime": {
"description": "Runs the app in a Node.js sandbox instead of an Oxygen worker.",
"env": "SHOPIFY_HYDROGEN_FLAG_LEGACY_RUNTIME",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/hydrogen/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default class Deploy extends Command {
}),
preview: Flags.boolean({
description:
'Deploys to the Preview environment. Overrides --env-branch and Git metadata.',
'Deploys to the Preview environment.',
required: false,
default: false,
}),
Expand Down
1 change: 0 additions & 1 deletion packages/cli/src/commands/hydrogen/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export default class Dev extends Command {
}),

// For the classic compiler:
worker: deprecated('--worker', {isBoolean: true}),
...overrideFlag(commonFlags.legacyRuntime, {
'legacy-runtime': {
description:
Expand Down
1 change: 0 additions & 1 deletion packages/cli/src/commands/hydrogen/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export default class Preview extends Command {
static flags = {
...commonFlags.path,
...commonFlags.port,
worker: deprecated('--worker', {isBoolean: true}),
...commonFlags.legacyRuntime,
...commonFlags.env,
...commonFlags.envBranch,
Expand Down
Loading