-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFAPI 2024-10 cart update #2572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
juanpprieto
reviewed
Oct 3, 2024
@@ -13,3 +13,11 @@ export const MINIMAL_CART_FRAGMENT = `#graphql | |||
checkoutUrl | |||
} | |||
`; | |||
|
|||
export const CART_WARNING_FRAGMENT = `#graphql | |||
fragment CartApiWarning on CartWarning { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
juanpprieto
approved these changes
Oct 3, 2024
rbshop
reviewed
Oct 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Update all cart mutation methods from
createCartHandler
to return cart warnings.As of API version 2024-10, inventory errors about stock levels will no longer be included in the
userErrors
of cart mutations. Inventory errors will now be available in a new return fieldwarnings
and will contain explicit code values ofMERCHANDISE_NOT_ENOUGH_STOCK
orMERCHANDISE_OUT_OF_STOCK
. Reference: https://shopify.dev/changelog/cart-warnings-in-storefront-api-cartUpgrade instructions
If your project is displaying inventory not enough and/or inventory out of stock errors by parsing cartUserErrors, make sure to update your code to parse cartWarnings instead.
PR description
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist