-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log GraphQLErrors automatically #1690
Conversation
This comment has been minimized.
This comment has been minimized.
Could we make I have been thinking how we can extend the ability of selectively suppressing errors to developers instead of just all console log or not. We do have a case of cart query returning graphql errors that can be safely ignored. (edit) I made the boolean function passing back single error after looking at your code. So it would be just
|
like this #1729 |
@wizardlyhel What about |
The new errors returned in
const {data, errors} = await storefront.query(...)
are likely to be missed because they are not breaking the flow.This PR adds an auto-logger for this type of error and enhances it with the query name.
Aside from that, I realized we were not showing the GraphiQL link anymore for this kind of error. This is fixed now: