Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow changesets for examples #1613

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Disallow changesets for examples #1613

merged 8 commits into from
Jan 8, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jan 5, 2024

I don't think we need changelogs/changesets for examples. The existing ones seem to be quite useless at least 🤔

turbo.json Outdated
"dependsOn": ["@shopify/hydrogen#build"]
},
"third-party-queries-caching#build": {
"example-*#build": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice shorthand!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem to be working, unfortunately

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@frandiox frandiox merged commit 0861d03 into main Jan 8, 2024
9 checks passed
@frandiox frandiox deleted the fd-examples-changeset branch January 8, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants