Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli-kit to 3.52 #1579

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Update cli-kit to 3.52 #1579

merged 5 commits into from
Dec 20, 2023

Conversation

frandiox
Copy link
Contributor

oxygen-cli is using 3.52 after #1575. This PRs updates cli-kit in hydrogen to keep it in sync, and removes some old bug workaround that has been fixed in latest cli-kit.

@frandiox frandiox requested a review from a team December 15, 2023 13:23
Comment on lines +1 to +10
---
'skeleton': patch
---

Update `@shopify/cli` dependency in `package.json`:

```diff
- "@shopify/cli": "3.51.0",
+ "@shopify/cli": "3.52.0",
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanpprieto do we need this kind of changeset? Or should we just rely on h2 upgrade?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do need this changeset so that it would trigger an overall update?

Should add '@shopify/cli-hydrogen': patch as well so that newly generated skeleton template will have the updated cli package version

Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add '@shopify/cli-hydrogen': patch as well so that newly generated skeleton template will have the updated cli package version

Comment on lines +1 to +5
---
'@shopify/cli-hydrogen': patch
---

Update cli-kit dependency for bug fixes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wizardlyhel it's already here 👀

@frandiox frandiox merged commit b0d727d into main Dec 20, 2023
9 checks passed
@frandiox frandiox deleted the fd-update-cli-kit-3.52 branch December 20, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants