-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli-kit to 3.52 #1579
Update cli-kit to 3.52 #1579
Conversation
--- | ||
'skeleton': patch | ||
--- | ||
|
||
Update `@shopify/cli` dependency in `package.json`: | ||
|
||
```diff | ||
- "@shopify/cli": "3.51.0", | ||
+ "@shopify/cli": "3.52.0", | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanpprieto do we need this kind of changeset? Or should we just rely on h2 upgrade
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do need this changeset so that it would trigger an overall update?
Should add '@shopify/cli-hydrogen': patch
as well so that newly generated skeleton template will have the updated cli package version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add '@shopify/cli-hydrogen': patch as well so that newly generated skeleton template will have the updated cli package version
--- | ||
'@shopify/cli-hydrogen': patch | ||
--- | ||
|
||
Update cli-kit dependency for bug fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wizardlyhel it's already here 👀
oxygen-cli
is using 3.52 after #1575. This PRs updates cli-kit in hydrogen to keep it in sync, and removes some old bug workaround that has been fixed in latest cli-kit.