Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy CFW DevTools for Workerd #1518

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Proxy CFW DevTools for Workerd #1518

merged 10 commits into from
Nov 21, 2023

Conversation

frandiox
Copy link
Contributor

This PR adds a proxy to the modified DevTools published by Cloudflare so that we can use them at localhost:9229.

image

It's a bit slow to load for the first time due to HTTP/1.1 request limit in localhost. We could add SSL or proxy this from https://inspect.hydrogen.app/... to speed it up with HTTP/2, but I think it's good enough 🤔

@frandiox
Copy link
Contributor Author

frandiox commented Nov 20, 2023

@juanpprieto It looks like the isClean fix in cli-kit was already released. I've changed the code here to fix that test.

Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@juanpprieto
Copy link
Contributor

@juanpprieto It looks like the isClean fix in cli-kit was already released. I've changed the code here to fix that test.

👍🏼 I ended up having to make this same change (along another) on my PR to fix upgrade tests on CI

@frandiox frandiox merged commit 2c9c2b7 into main Nov 21, 2023
8 of 9 checks passed
@frandiox frandiox deleted the fd-workerd-devtools branch November 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants