Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codegen js generate #1467

Closed
wants to merge 5 commits into from
Closed

Fix codegen js generate #1467

wants to merge 5 commits into from

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

shopify hydrogen codegen command is giving errors when the project is build with JavaScript

Screenshot 2023-10-30 at 1 30 55 PM

Reason being that codegen is looking for ts|tsx files when generating a default config

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@wizardlyhel wizardlyhel deleted the fix-codegen-js-generate branch October 30, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wizardlyhel